From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UnYaa-0003mz-AV
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 14:19:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UnYaY-0003di-UE
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 14:19:08 -0400
Received: from e39.co.us.ibm.com ([32.97.110.160]:51323)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UnYaY-0003dW-NK
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 14:19:06 -0400
Received: from /spool/local
	by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Fri, 14 Jun 2013 12:19:05 -0600
Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 84ED838C8047
	for <qemu-devel@nongnu.org>; Fri, 14 Jun 2013 14:19:02 -0400 (EDT)
Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195])
	by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r5EIJ3hh344226
	for <qemu-devel@nongnu.org>; Fri, 14 Jun 2013 14:19:03 -0400
Received: from d01av05.pok.ibm.com (loopback [127.0.0.1])
	by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r5EIJ2EG004177
	for <qemu-devel@nongnu.org>; Fri, 14 Jun 2013 14:19:02 -0400
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <CAFEAcA_Sj8oa=0XNmKapNkz7coCvZ6-oanM1MmMtHAoRX63jaA@mail.gmail.com>
References: <1370606325-10680-1-git-send-email-stefanha@redhat.com>
	<1370606325-10680-22-git-send-email-stefanha@redhat.com>
	<CAFEAcA9F8vmhP1PTGuzi5sxbTtg3RW4_j-swmVZG+RNZHnYAWA@mail.gmail.com>
	<CAFEAcA_Sj8oa=0XNmKapNkz7coCvZ6-oanM1MmMtHAoRX63jaA@mail.gmail.com>
Date: Fri, 14 Jun 2013 13:18:44 -0500
Message-ID: <87ppvopncr.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

Peter Maydell <peter.maydell@linaro.org> writes:

> On 14 June 2013 18:54, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 7 June 2013 12:58, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>> From: Kevin Wolf <kwolf@redhat.com>
>>>
>>> This checks in particular that BSY is set while the flush request is in
>>> flight.
>>
>> This test doesn't seem to pass.
>
>> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/ide-test.c:460:test_flush:
>> assertion failed ((data) & (BSY | DF | ERR | DRQ) == 0): (0x00000080
>> == 0x00000000)
>
> ...fixed by http://patchwork.ozlabs.org/patch/250334/

I'm testing it myself now.  Since it's already in the block tree, I'll
push it directly as it's blocking my queue.

Unless Kevin or Stefan are planning on sending a pull request today of
course.

Regards,

Anthony Liguori

>
> thanks
> -- PMM