From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UXBtq-0005Hn-5T
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 10:51:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UXBtp-0002Ob-0w
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 10:51:22 -0400
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:40507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UXBto-0002OE-FO
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 10:51:20 -0400
Received: from /spool/local
	by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Wed, 1 May 2013 00:41:48 +1000
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <1367250772-17928-1-git-send-email-jlarrew@linux.vnet.ibm.com>
References: <1367250772-17928-1-git-send-email-jlarrew@linux.vnet.ibm.com>
Date: Tue, 30 Apr 2013 09:51:08 -0500
Message-ID: <87ppxcnkbn.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] libqtest: only call fclose() on open files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jesse Larrew <jlarrew@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org

Jesse Larrew <jlarrew@linux.vnet.ibm.com> writes:

> libqtest.c can segfault when calling fclose() if the pidfile wasn't
> opened successfully. This patch fixes the issue.
>
> Signed-off-by: Jesse Larrew <jlarrew@linux.vnet.ibm.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  tests/libqtest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 884f959..879ffe9 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -99,8 +99,8 @@ static pid_t qtest_qemu_pid(QTestState *s)
>          if (fgets(buffer, sizeof(buffer), f)) {
>              pid = atoi(buffer);
>          }
> +        fclose(f);
>      }
> -    fclose(f);
>      return pid;
>  }
>  
> -- 
> 1.7.11.7