Re: [Qemu-devel] [PULL 00/34] migration thread and queue

[Juan Quintela <quintela@redhat.com>]

Juan Quintela <quintela@redhat.com> wrote:
> Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Juan Quintela <quintela@redhat.com> writes:
>>
>>> Hi
>>>
>>> Changes for yesterday:
>>> - Paolo Acked the series
>>> - Rebaso on top of today git (only conflicts were due to header re-shuffle)
>>>
>>> Please pull.
>>>
>>> [20121219]
>>>
>>> This is my queue for migration-thread and patches associated.  This
>>> integrates review comments & code for Paolo.  This is the subset from
>>> both approachs that we agreed with. rest of patches need more review
>>> and are not here.
>>
>> This breaks migration.  Here's my test case:
>>
>> #!/bin/sh
>>
>> gzip -d -c lidb.ssmall.img.gz | \
>>     ~/build/qemu/x86_64-softmmu/qemu-system-x86_64 -cdrom \
>>     ~/isos/OCDC-lucid-Test-Drive-20110523_140333.iso -enable-kvm -m 2G \
>>     -incoming exec:dd
>>
>> With lidb.ssmall.img.gz being generated from a 'migrate exec:dd of=...'
>> from qemu.git just a week or two ago.
>>
>> I can't bisect tonight but can attempt to tomorrow.  How has this been
>> tested?
>
> I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM.
> Will test tomorrow with your test case.  I didn't tested exec:, though.
>
>>
>> I'm a little concerned here about the timing.  With the Christmas
>> and New Years holiday we're pretty darn close to soft freeze for 1.4.
>>
>> Has this series gone through a full autotest run with multiple guests?
>
> Will re-test tomorrow with autotest.

Tested with autotest, it worked both upstream and the pull request.

Anthony, any news about your problems?

Can you pull the series?

Or do you preffer that I integrate Paolo fixes in the middle and sent
another pull request?

Thanks, Juan.