From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTXnw-0000X8-15 for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTXnn-0000D0-OK for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:53:55 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:60867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTXnn-0000B9-0o for qemu-devel@nongnu.org; Wed, 31 Oct 2012 08:53:47 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 Oct 2012 18:23:42 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9VCrcse4260172 for ; Wed, 31 Oct 2012 18:23:38 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9VINT5C024501 for ; Thu, 1 Nov 2012 05:23:29 +1100 From: Anthony Liguori In-Reply-To: <20121031100458.GE12521@redhat.com> References: <2be648d47fa2cfb210c18dda0a3fb03cffd621e1.1351561225.git.jbaron@redhat.com> <87zk33u5ud.fsf@codemonkey.ws> <20121031100458.GE12521@redhat.com> Date: Wed, 31 Oct 2012 07:53:16 -0500 Message-ID: <87pq3y4xc3.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset emulator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: agraf@suse.de, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, kraxel@redhat.com "Michael S. Tsirkin" writes: > On Tue, Oct 30, 2012 at 02:18:02PM -0500, Anthony Liguori wrote: >> Jason Baron writes: >> >> > From: Isaku Yamahata >> > >> > pc q35 based chipset emulator to support pci express natively. Based on >> > Anthony Liguori's suggestion, the machine name is 'q35-next', with an alias >> > of 'q35'. At this point, there are no compatibility guarantees. When the >> > chipset stabilizes more, we will begin to version the machine names. >> > >> > Major features which still need to be added: >> > >> > -Migration support (mostly around ahci) >> > -ACPI hotplug support (pcie hotplug support is working) >> > -Passthrough support >> > >> > Signed-off-by: Isaku Yamahata >> > Signed-off-by: Jason Baron >> > --- >> > hw/i386/Makefile.objs | 2 +- >> > hw/pc.h | 2 + >> > hw/pc_piix.c | 4 +- >> > hw/pc_q35.c | 326 +++++++++++++++++++++++++++++++++++++++++++++++++ >> > hw/pci_ids.h | 2 + >> > hw/q35.c | 315 +++++++++++++++++++++++++++++++++++++++++++++++ >> > hw/q35.h | 161 ++++++++++++++++++++++++ >> > 7 files changed, 809 insertions(+), 3 deletions(-) >> > create mode 100644 hw/pc_q35.c >> > create mode 100644 hw/q35.c >> > create mode 100644 hw/q35.h >> > >> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >> > index 693bd18..469b127 100644 >> > --- a/hw/i386/Makefile.objs >> > +++ b/hw/i386/Makefile.objs >> > @@ -7,7 +7,7 @@ obj-y += debugcon.o multiboot.o >> > obj-y += pc_piix.o >> > obj-y += pc_sysfw.o >> > obj-y += pam.o >> > -obj-y += acpi_ich9.o lpc_ich9.o smbus_ich9.o >> > +obj-y += acpi_ich9.o lpc_ich9.o smbus_ich9.o q35.o pc_q35.o >> >> This shouldn't be here. It should be in hw/Makefile.objs. >> >> This is not target specific code. > > What about acpi_ich9.o lpc_ich9.o smbus_ich9.o? Should it move to Makefile.objs too? > > How is this different from pc_piix? Yes, everything should be in Makefile.objs unless it depends on CPUState. Regards, Anthony Liguori > > -- > MST