From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9vPU-0004gg-Ru for qemu-devel@nongnu.org; Sat, 01 Oct 2011 04:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9vPT-0007xj-EF for qemu-devel@nongnu.org; Sat, 01 Oct 2011 04:59:04 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:35506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9vPT-0007xR-Bl for qemu-devel@nongnu.org; Sat, 01 Oct 2011 04:59:03 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p918huDp022143 for ; Sat, 1 Oct 2011 04:43:56 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p918wvqr262662 for ; Sat, 1 Oct 2011 04:58:57 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p918wulI024654 for ; Sat, 1 Oct 2011 02:58:56 -0600 From: "Aneesh Kumar K.V" In-Reply-To: References: <20110929232824.7CBA73FC28@buildbot.b1-systems.de> Date: Sat, 01 Oct 2011 14:28:47 +0530 Message-ID: <87pqih2im0.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: gollub@b1-systems.de, lcapitulino@redhat.com, qemu-devel@nongnu.org, agraf@suse.de On Fri, 30 Sep 2011 09:26:53 +0100, Stefan Hajnoczi wr= ote: > On Fri, Sep 30, 2011 at 12:28 AM, wrote: > > The Buildbot has detected a new failure on builder default_x86_64_rhel5= while building qemu. > > Full details are available at: > > =C2=A0http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/= builds/24 >=20 > Build error on RHEL 5 in virtio-9p-handle.c: > /home/buildbot/slave-public/default_x86_64_rhel5/build/hw/9pfs/virtio-9p-= handle.c: > In function 'handle_utimensat': > /home/buildbot/slave-public/default_x86_64_rhel5/build/hw/9pfs/virtio-9p-= handle.c:377: > warning: implicit declaration of function 'futimens' > /home/buildbot/slave-public/default_x86_64_rhel5/build/hw/9pfs/virtio-9p-= handle.c:377: > warning: nested extern declaration of 'futimens' >=20 > RHEL 5 only has glibc 2.5 but futimens(2) was introduced in glibc 2.6. We can make handle only available to glibc 2.6 and above . Handle fs drive will anyhow require a 2.6.39 kernel. Something like. diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c index 860b0e3..a7a8930 100644 --- a/hw/9pfs/virtio-9p-handle.c +++ b/hw/9pfs/virtio-9p-handle.c @@ -390,7 +390,13 @@ static int handle_utimensat(FsContext *ctx, V9fsPath *= fs_path, if (fd < 0) { return fd; } +#if __GLIBC__ >=3D 2 && __GLIBC_MINOR__ >=3D 6 + /* futimens is only available with glibc 2.6 and above.*/ ret =3D futimens(fd, buf); +#else + ret =3D -1; + errno =3D ENOSYS; +#endif close(fd); return ret; } @@ -591,8 +597,16 @@ static int handle_init(FsContext *ctx) int ret, mnt_id; struct statfs stbuf; struct file_handle fh; - struct handle_data *data =3D g_malloc(sizeof(struct handle_data)); + struct handle_data *data; =20 +#if __GLIBC__ <=3D 2 && __GLIBC_MINOR__ < 6 + /* + * We support only above glibc 2.6. Older distro will anyhow + * not have handle syscall support in the kernel. + */ + return -1; +#endif + data =3D g_malloc(sizeof(struct handle_data)); data->mountfd =3D open(ctx->fs_root, O_DIRECTORY); if (data->mountfd < 0) { ret =3D data->mountfd;