qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Juraj Marcin <jmarcin@redhat.com>,
	peterx@redhat.com, Pawel Zmarzly <pzmarzly0@gmail.com>,
	michel@michel-slm.name
Subject: Re: [PATCH RFC] tests/migration-test: Add mapped-ram + ignore-shared test
Date: Tue, 25 Nov 2025 18:40:50 -0300	[thread overview]
Message-ID: <87qztleqot.fsf@suse.de> (raw)
In-Reply-To: <20251125194003.833842-1-peterx@redhat.com>

Peter Xu <peterx@redhat.com> writes:

> It was broken, add a test for it.
>
> NOTE: here we do not really need any shared memory blocks, enabling of both
> of the features alone would cover the ramblock layout difference that the
> bug triggers.
>
> Cc: Pawel Zmarzly <pzmarzly0@gmail.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Cc: michel@michel-slm.name
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>
> RFC because currently master branch is broken with it, so need to merge
> only after a proper fix lands.
>
> Pawel, feel free to take this with your fix when repost, or I'll manage.
> ---
>  tests/qtest/migration/file-tests.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/tests/qtest/migration/file-tests.c b/tests/qtest/migration/file-tests.c
> index 4d78ce0855..ab1b477bdf 100644
> --- a/tests/qtest/migration/file-tests.c
> +++ b/tests/qtest/migration/file-tests.c
> @@ -137,6 +137,22 @@ static void test_precopy_file_mapped_ram(void)
>      test_file_common(&args, true);
>  }
>  
> +static void test_precopy_file_mapped_ram_ignore_share(void)

s/share/shared/

Acked-by: Fabiano Rosas <farosas@suse.de>


  reply	other threads:[~2025-11-25 21:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 19:40 [PATCH RFC] tests/migration-test: Add mapped-ram + ignore-shared test Peter Xu
2025-11-25 21:40 ` Fabiano Rosas [this message]
2025-11-26 12:16   ` Paweł Zmarzły

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qztleqot.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=michel@michel-slm.name \
    --cc=peterx@redhat.com \
    --cc=pzmarzly0@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).