From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness
Date: Wed, 11 Oct 2023 15:24:33 +0200 [thread overview]
Message-ID: <87r0m19tri.fsf@secure.mitica> (raw)
In-Reply-To: <20231009184326.15777-6-farosas@suse.de> (Fabiano Rosas's message of "Mon, 9 Oct 2023 15:43:25 -0300")
Fabiano Rosas <farosas@suse.de> wrote:
> The migration code uses unsigned values for 16, 32 and 64-bit
> operations. Fix the script to do the same.
>
> This was causing an issue when parsing the migration stream generated
> on the ppc64 target because one of instance_ids was larger than the
> 32bit signed maximum:
>
> Traceback (most recent call last):
> File "/home/fabiano/kvm/qemu/build/scripts/analyze-migration.py", line 658, in <module>
> dump.read(dump_memory = args.memory)
> File "/home/fabiano/kvm/qemu/build/scripts/analyze-migration.py", line 592, in read
> classdesc = self.section_classes[section_key]
> KeyError: ('spapr_iommu', -2147483648)
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-10-11 13:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 18:43 [PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test Fabiano Rosas
2023-10-09 18:43 ` [PATCH v2 1/6] migration: Add the configuration vmstate to the json writer Fabiano Rosas
2023-10-11 13:12 ` Juan Quintela
2023-10-11 13:33 ` Fabiano Rosas
2023-10-09 18:43 ` [PATCH v2 2/6] migration: Fix analyze-migration.py 'configuration' parsing Fabiano Rosas
2023-10-11 13:16 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 3/6] migration: Add capability parsing to analyze-migration.py Fabiano Rosas
2023-10-11 13:22 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used Fabiano Rosas
2023-10-11 13:23 ` Juan Quintela
2023-10-11 13:32 ` Fabiano Rosas
2023-10-11 14:10 ` Juan Quintela
2023-10-09 18:43 ` [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness Fabiano Rosas
2023-10-11 13:24 ` Juan Quintela [this message]
2023-10-09 18:43 ` [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script Fabiano Rosas
2023-10-10 7:11 ` Thomas Huth
2023-10-11 13:28 ` Juan Quintela
2023-10-11 13:35 ` Fabiano Rosas
2023-10-10 20:27 ` [PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0m19tri.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=crosa@redhat.com \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).