From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE057C7EE22 for ; Wed, 10 May 2023 08:45:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwfR6-0007eL-Jg; Wed, 10 May 2023 04:44:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwfR5-0007df-Gk for qemu-devel@nongnu.org; Wed, 10 May 2023 04:44:35 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwfR3-0002pj-DH for qemu-devel@nongnu.org; Wed, 10 May 2023 04:44:35 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3f42d937d2eso8495065e9.2 for ; Wed, 10 May 2023 01:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683708271; x=1686300271; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=gyU0kcV9vkZrsW69f1JBVp8THmK2dLQWbgwsuYgm31M=; b=in6ZgQNhPTS2Ltyo610mmfkO/DqHyNTyErOLdFy2stkNFiVHekJL1+rBR/+grp/mk+ WDlJ6/JWDOqSFw1Ok6zkbfFZGA7WLEYSd9ShSUL/8WQKYVv+Vo03wNhuLQ0AAJ9RRwaM x75hC8UScxkbKjU7Ewkjd/7LHHK/KlriEEIDLsE2J/xhwoMhYHXx0rBgKwNGiDYOdxti Zc0tCHzelAcM61tu2UOLNbK+QiSwoZ3xT10nlCg7cFY6e0m01F8mGmCHbzNRfgGvLaA5 XvFcmWO61VN9mEmn10vaQC4zz8arrLu2dmMofHg2R2YYg6FlcFDcMB6ojOjcC9cjkUC+ T1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683708271; x=1686300271; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gyU0kcV9vkZrsW69f1JBVp8THmK2dLQWbgwsuYgm31M=; b=a3QtmbmQP94kq50Hz91Li5n4zVw2aKt1UTjwghBPcLI8l4BynFfqU3Lb6PbBJ7cp7o vSpzFe6NFmUZOZBwrpv5GQswWdYZ0BA6GX3fkFKUtVyl71STTEdeYwpnqNyom5Ol5WMM sORUcXEuMBp7IyhYUA5TZRpI6+MrnFp1Pmyxcm77TTap+sCkOBO7yjdzyy6NHY3grazV ONGLQADMhQ7c5nW41Bet9PAYXKDcVKFLz1lQArkP6CQG39TdJL4+8MXlxm06K8X4nD65 cbuW9QUATpPIUUowbyZeULW2rxTsTHWEk5qxroG5svSMK4qIEFUFKuA7SmQ4Cdl9SoGk GMQA== X-Gm-Message-State: AC+VfDwfpSySh20cOkAGLc/0v4Yl+Hxnp29qb6WrIco3QZ1ITUrwwdZM SxZqZc4kVWxocKJ3SpI7yZ6Vzw== X-Google-Smtp-Source: ACHHUZ6wMUHZBiBy9puMpXUi5YmNQa7ZTcR4KgwipBtQXRx8mqlpYNcmbPpvks+lD7YVlk+NrrTNEg== X-Received: by 2002:a1c:7c10:0:b0:3f4:2610:5cc1 with SMTP id x16-20020a1c7c10000000b003f426105cc1mr6929273wmc.1.1683708270812; Wed, 10 May 2023 01:44:30 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id g22-20020a7bc4d6000000b003f049a42689sm21845194wmk.25.2023.05.10.01.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 01:44:30 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C97971FFBB; Wed, 10 May 2023 09:44:29 +0100 (BST) References: <20230506072235.597467-1-richard.henderson@linaro.org> <20230506072235.597467-3-richard.henderson@linaro.org> User-agent: mu4e 1.11.4; emacs 29.0.90 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Cc: git@xen0n.name, gaosong@loongson.cn, philmd@linaro.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH v5 02/30] tcg/i386: Use indexed addressing for softmmu fast path Date: Wed, 10 May 2023 09:44:18 +0100 In-reply-to: <20230506072235.597467-3-richard.henderson@linaro.org> Message-ID: <87r0roa842.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Richard Henderson writes: > Since tcg_out_{ld,st}_helper_args, the slow path no longer requires > the address argument to be set up by the tlb load sequence. Use a > plain load for the addend and indexed addressing with the original > input address register. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro