From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH] multifd: Fix the number of channels ready
Date: Wed, 26 Apr 2023 19:35:27 +0200 [thread overview]
Message-ID: <87r0s6eecg.fsf@secure.mitica> (raw)
In-Reply-To: <87354mmudb.fsf@suse.de> (Fabiano Rosas's message of "Wed, 26 Apr 2023 14:22:08 -0300")
Fabiano Rosas <farosas@suse.de> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> We don't wait in the sem when we are doing a sync_main. Make it wait
>> there. To make things clearer, we mark the channel ready at the
>> begining of the thread loop.
>
> So in other words we're estabilishing that "channel ready" means ready
> to send, regardless of having sent the sync packet. Is that it?
Yeap.
There was a bug (from the beggining) that made the counter always get
up and up. This fixes it.
It was always supposed to work this way.
/me puts (second time in the week) a brown paper bag on head
Later, Juan.
next prev parent reply other threads:[~2023-04-26 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 16:23 [PATCH] multifd: Fix the number of channels ready Juan Quintela
2023-04-26 17:22 ` Fabiano Rosas
2023-04-26 17:35 ` Juan Quintela [this message]
2023-04-26 17:58 ` Fabiano Rosas
2023-04-26 17:58 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0s6eecg.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).