From: "Alex Bennée" <alex.bennee@linaro.org>
To: tanhongze <tanhongze@loongson.cn>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] target/loongarch: Enables plugins to get instruction codes
Date: Mon, 03 Apr 2023 14:11:56 +0100 [thread overview]
Message-ID: <87r0t1m7nk.fsf@linaro.org> (raw)
In-Reply-To: <20230330124600.1523026-1-tanhongze@loongson.cn>
tanhongze <tanhongze@loongson.cn> writes:
> Signed-off-by: tanhongze <tanhongze@loongson.cn>
It looks like you've missed the review tags from the last posting.
Acked-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/loongarch/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
> index 3bb63bfb3e..50d6b62f39 100644
> --- a/target/loongarch/translate.c
> +++ b/target/loongarch/translate.c
> @@ -198,7 +198,7 @@ static void loongarch_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
> CPULoongArchState *env = cs->env_ptr;
> DisasContext *ctx = container_of(dcbase, DisasContext, base);
>
> - ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
> + ctx->opcode = translator_ldl(env, &ctx->base, ctx->base.pc_next);
>
> if (!decode(ctx, ctx->opcode)) {
> qemu_log_mask(LOG_UNIMP, "Error: unknown opcode. "
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2023-04-03 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 12:46 [PATCH v2] target/loongarch: Enables plugins to get instruction codes tanhongze
2023-04-03 13:11 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0t1m7nk.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tanhongze@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).