* [PATCH v2] target/loongarch: Enables plugins to get instruction codes
@ 2023-03-30 12:46 tanhongze
2023-04-03 13:11 ` Alex Bennée
0 siblings, 1 reply; 2+ messages in thread
From: tanhongze @ 2023-03-30 12:46 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: tanhongze <tanhongze@loongson.cn>
---
target/loongarch/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
index 3bb63bfb3e..50d6b62f39 100644
--- a/target/loongarch/translate.c
+++ b/target/loongarch/translate.c
@@ -198,7 +198,7 @@ static void loongarch_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
CPULoongArchState *env = cs->env_ptr;
DisasContext *ctx = container_of(dcbase, DisasContext, base);
- ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
+ ctx->opcode = translator_ldl(env, &ctx->base, ctx->base.pc_next);
if (!decode(ctx, ctx->opcode)) {
qemu_log_mask(LOG_UNIMP, "Error: unknown opcode. "
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] target/loongarch: Enables plugins to get instruction codes
2023-03-30 12:46 [PATCH v2] target/loongarch: Enables plugins to get instruction codes tanhongze
@ 2023-04-03 13:11 ` Alex Bennée
0 siblings, 0 replies; 2+ messages in thread
From: Alex Bennée @ 2023-04-03 13:11 UTC (permalink / raw)
To: tanhongze; +Cc: qemu-devel
tanhongze <tanhongze@loongson.cn> writes:
> Signed-off-by: tanhongze <tanhongze@loongson.cn>
It looks like you've missed the review tags from the last posting.
Acked-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/loongarch/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
> index 3bb63bfb3e..50d6b62f39 100644
> --- a/target/loongarch/translate.c
> +++ b/target/loongarch/translate.c
> @@ -198,7 +198,7 @@ static void loongarch_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
> CPULoongArchState *env = cs->env_ptr;
> DisasContext *ctx = container_of(dcbase, DisasContext, base);
>
> - ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
> + ctx->opcode = translator_ldl(env, &ctx->base, ctx->base.pc_next);
>
> if (!decode(ctx, ctx->opcode)) {
> qemu_log_mask(LOG_UNIMP, "Error: unknown opcode. "
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-03 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-30 12:46 [PATCH v2] target/loongarch: Enables plugins to get instruction codes tanhongze
2023-04-03 13:11 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).