From: "Alex Bennée" <alex.bennee@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Vitaly Buka <vitalybuka@google.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED
Date: Thu, 11 Aug 2022 16:18:39 +0100 [thread overview]
Message-ID: <87r11miz8i.fsf@linaro.org> (raw)
In-Reply-To: <52225a7c-310f-444f-0b75-0ad2536a30c0@vivier.eu>
Laurent Vivier <laurent@vivier.eu> writes:
> Le 11/08/2022 à 13:54, Peter Maydell a écrit :
>> On Thu, 11 Aug 2022 at 09:29, Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>> Le 10/08/2022 à 22:47, Richard Henderson a écrit :
>>>> On 8/10/22 13:32, Vitaly Buka wrote:
>>>>> Sorry, I only noticed today that it's not submitted.
>>>>> Version is not critical for us, as we build from masters anyway.
>>>>> Richard, do you know a reason to consider this critical?
>>>>>
>>>>> On Wed, 10 Aug 2022 at 13:04, Peter Maydell <peter.maydell@linaro.org
>>>>> <mailto:peter.maydell@linaro.org>> wrote:
>>>>>
>>>>> On Wed, 10 Aug 2022 at 21:00, Vitaly Buka <vitalybuka@google.com
>>>>> <mailto:vitalybuka@google.com>> wrote:
>>>>> >
>>>>> > How can we land this one?
>>>>>
>>>>> Pinging it a week ago rather than now would have been a good start :-(
>>>>> I think it got missed because you didn't cc the linux-user maintainer.
>>>>>
>>>>> Is this a critical fix for 7.1 or can we let it slip to 7.2 ?
>>>>
>>>> It's unfortunate that it got missed. It's not critical, but it would be nice, because support for
>>>> MADV_DONTNEED is new in 7.1 (previously, we ignored all madvise).
>>>>
>>>> I'll note there are missing braces for coding style on an IF.
>>>>
>>>> Laurent, do you have an objection to merging this for rc3?
>>>>
>>>
>>> No objection.
>>>
>>> Do you want it goes via the arm branch or via the linux-user branch?
>>>
>>> If it goes via linux-user I can run the LTP testsuite but it takes 1 day.
>> I think we should definitely run the LTP testsuite on it, so
>> taking it via linux-user probably makes more sense.
>
> ok, applied to my linux-user-for-7.1 branch.
>
> Running tests.
Any chance you could pick up:
Subject: [PATCH v2] linux-user: un-parent OBJECT(cpu) when closing thread
Date: Wed, 3 Aug 2022 14:05:37 +0100
Message-Id: <20220803130537.763666-1-alex.bennee@linaro.org>
before you run the tests?
>
> Thanks,
> Laurent
--
Alex Bennée
next prev parent reply other threads:[~2022-08-11 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 19:59 [PATCH] [PATCH] linux-user/aarch64: Reset target data on MADV_DONTNEED Vitaly Buka
2022-08-10 20:03 ` Peter Maydell
2022-08-10 20:32 ` Vitaly Buka
2022-08-10 20:47 ` Richard Henderson
2022-08-11 8:29 ` Laurent Vivier
2022-08-11 11:54 ` Peter Maydell
2022-08-11 12:27 ` Laurent Vivier
2022-08-11 15:18 ` Alex Bennée [this message]
2022-08-13 15:54 ` Laurent Vivier
2022-08-16 8:41 ` Alex Bennée
2022-08-16 10:50 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2022-07-11 22:00 Vitaly Buka
2022-07-12 4:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r11miz8i.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vitalybuka@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).