From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577C6C4338F for ; Thu, 12 Aug 2021 15:25:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCBBB6108C for ; Thu, 12 Aug 2021 15:25:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BCBBB6108C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mECZv-0004Sf-Au for qemu-devel@archiver.kernel.org; Thu, 12 Aug 2021 11:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mECZ9-0002tb-QX for qemu-devel@nongnu.org; Thu, 12 Aug 2021 11:24:19 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:53117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mECZ8-0003Mn-7o for qemu-devel@nongnu.org; Thu, 12 Aug 2021 11:24:19 -0400 Received: by mail-wm1-x330.google.com with SMTP id f10so1675301wml.2 for ; Thu, 12 Aug 2021 08:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=iWO/8fBupg3zWsLFRus4HfAH3y+LCg/9xyQFGKFT6Eg=; b=bITspaQlOLRNCb2KQMFI+5r4KxMz+HmPN0S0By67AyjFEvkyOoO7DX4Nhgp+Dw38vh j0iMiQcQeetJuQ1Rj+BI6B+kR/PjtGK9RGcStmfWuByrXI1UnmwaL2Jug6SmZp/BRFMC W+FyViZoTpgbKrjy6W0zVOX3gtjHZ3WS/9yJ0LROZZLaFtFjioO+9NXYwp4bEz11slBq ub9UG0upelMZUVw+l/NmoLp4Hy4CrTym8dUxvIzpSd8IrQR1+h/UAAKm1Q9usJJj81ln MI8ajntW3OVNbWyv/dpqHAYphzk6q27Fr/F4wTWOPTz1jfvtOUmHV37EXz/vmYJasYWG Guuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=iWO/8fBupg3zWsLFRus4HfAH3y+LCg/9xyQFGKFT6Eg=; b=ojEBd1I4c+yGfJQ0G9wfLuFQqZZ6IXn+whO1uMluov5dfLYaqyl/I/FQ8COUYaDhRt Qj+hJmsJ1fQNhRrIBhjHkup6KIKIIL89rqCv1yMcYdL5xlEZVC1ZRXsWUfPw4DFYmQOd LAVCnDccxrL2dj/q1Upl7u7Nl7pZALvn/L3UvbrV+5RMWdDPnUljlgbPg3qxHeRsKDX2 /MAFxpm6/GylXojwOuchD3dGiWM3L42tRGpad3HWMbKn+hoIq1B2X2aRTMoncQjZyUsy gbePOi86cAkDXrDOMO7XAUw9G96glSpN3qNiA8rg/B14n0u504yyJt41OXd712AvsXcs 3Lrg== X-Gm-Message-State: AOAM5327Iq0Cnbp9T2ha4UkOGnhw0iBbptWbttQ00aX5YPYEe5tlKYk9 QzNDnn8U1lJ+VCqJnnZ6NyzxOw== X-Google-Smtp-Source: ABdhPJyTkVP/ycMLS0e+oQidVJIVp3UZsWCcoaPLq2c5mHtUCGlH+tGZ5nLSnnNr9caPpxWoG3FZ1Q== X-Received: by 2002:a7b:c922:: with SMTP id h2mr9671735wml.186.1628781856746; Thu, 12 Aug 2021 08:24:16 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id l12sm2808117wms.24.2021.08.12.08.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 08:24:15 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DA2051FF96; Thu, 12 Aug 2021 16:24:14 +0100 (BST) References: <20210811100550.54714-1-pbonzini@redhat.com> <875ywb6lxu.fsf@linaro.org> User-agent: mu4e 1.6.2; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Paolo Bonzini Subject: Re: [PATCH for 6.1] plugins: do not limit exported symbols if modules are active Date: Thu, 12 Aug 2021 16:19:16 +0100 In-reply-to: Message-ID: <87r1eyznxd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Maydell, Peter" , Yonggang Luo , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Paolo Bonzini writes: > Il gio 12 ago 2021, 11:40 Alex Benn=C3=A9e ha sc= ritto: > > ERROR: glib-2.56 gmodule-noexport-2.0 is required to compile QEMU > > Should it be gmodule-no-export? Hopefully the different distros aren't > packaging different .pc files. > > My bad. :( It's correct with the dash. I've patched it locally and it's sitting in my PR branch: https://gitlab.com/stsquad/qemu/-/commits/pr/120821-for-6.1-rc4-1 but it looks like it will have to go via stable unless there is a more compelling reason to cut an rc4. > Does this mean --enable-modules would allow plugins to access more of > the API space than we intended in the first place? > > Yes, but before it would do so even without --enable-modules due to > using gmodule and not gmodule-no-export. OK so it's better now. I wonder if this helps with the Windows usage of modules? Subject: [PATCH v6 0/5] Enable plugin support on msys2/mingw Date: Tue, 13 Oct 2020 08:28:01 +0800 Message-Id: <20201013002806.1447-1-luoyonggang@gmail.com> I really want to avoid the hand hacking of Youngang's proposed changes so was surprised that glib hadn't papered over the POSIX/Windows cracks. However like MacOS I don't have easy access to a Windows developer system to experiment with. --=20 Alex Benn=C3=A9e