From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBE9C07E95 for ; Tue, 20 Jul 2021 10:50:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E71816108B for ; Tue, 20 Jul 2021 10:50:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E71816108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5nKZ-0005XS-Sh for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 06:50:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5nJa-0004rW-48 for qemu-devel@nongnu.org; Tue, 20 Jul 2021 06:49:30 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5nJY-0003YQ-E8 for qemu-devel@nongnu.org; Tue, 20 Jul 2021 06:49:29 -0400 Received: by mail-wr1-x436.google.com with SMTP id c15so1896834wrs.5 for ; Tue, 20 Jul 2021 03:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=eLc4OIXu2bOU8HkLTEW+P6UaV/PN5DR5iKbTzcIQQZA=; b=pNgWRH0ARaFccO8t3yp9kHU0nmC7bUilbYTsdNJb9Dpu8Sc9pA6SGS8+GVyCdIoIjo vmdwDc/ot/XzXmO/FjS04uBiDPjeEZFHs8Dh98ZfkgbZKxYWuAHlBAj1hgXycvLEBPUK G1NTtSoA64jdqHDb2zRl6uZ8wd9d/t+rpMqxEoFhIGsWWwgqsmlkYp+jT9rA1FTdbF0B /kQmFV2xrfoibRLqEhKgZ31Y/s58JeqGxTFtXwdEXMGAbgEHxbnHPKJm7lJ5/XyHKayZ YL/fvZ+dR6HpNN0zDKao2kgGnKDtW4dQXQpxFjoTNKOxgH7I1iDM71P8dloBNB2FiImB ex8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=eLc4OIXu2bOU8HkLTEW+P6UaV/PN5DR5iKbTzcIQQZA=; b=My+Y973BmVYDG3QEnYs1023KIyr2vbTahmEmfOhmowvVeopSHWbsC0CgqAaehCuQBG k/WCuZg7u/8BNpCxZGVuBKRheb8Ip73sDOoWi8dwzs6Rq5JoM76ZLZxMum81T3NvTMfm 5n2WlGE23LsWRKnQblhQN5rAO1lVss3SZC0EzoeLPadxPJw7SQtoX9M33Hz43MKsmlvw OOyYwQjp1CEwiK42SmZWAiaC0zGjuT29ADof1ASp9K7RA1AHnwlaXeDVpJPpNN1SPtcH c8q8kUH66g1i0cJ0WRJnmAfgjtt2Dagl3ft22YhQ0xJKsgQCfT5QIA8CSaf3yZIB42Cm aN5g== X-Gm-Message-State: AOAM531Jfz2k8bvNByqj/H9sLnquvEh850SFKMUQmVKni0gLId70WGnW EafxulNFGV1mulNoDDPE480EwQ== X-Google-Smtp-Source: ABdhPJyv5YlztfuIzit6XYInOZ/tiiMchNo0ar+YRXLanUzq9bhWgIgtJzuuEiMI2edfcpoMf/+71A== X-Received: by 2002:a5d:4561:: with SMTP id a1mr34194543wrc.259.1626778166771; Tue, 20 Jul 2021 03:49:26 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z7sm10110656wrt.94.2021.07.20.03.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 03:49:25 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 38B821FF7E; Tue, 20 Jul 2021 11:49:25 +0100 (BST) References: <20210719195002.6753-1-alex.bennee@linaro.org> <20210719195002.6753-2-alex.bennee@linaro.org> <87zguhmi4p.fsf@linaro.org> User-agent: mu4e 1.5.14; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Subject: Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard Date: Tue, 20 Jul 2021 11:35:11 +0100 In-reply-to: Message-ID: <87r1ftmf9m.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , f4bug@armsat.org, QEMU Developers , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Tue, 20 Jul 2021 at 10:47, Alex Benn=C3=A9e w= rote: >> >> >> Peter Maydell writes: >> >> > On Mon, 19 Jul 2021 at 20:52, Alex Benn=C3=A9e wrote: >> >> >> >> We inadvertently added a symbol clash causing the build not to include >> >> the testboard needed for check-tcg. >> >> >> >> Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") >> >> Signed-off-by: Alex Benn=C3=A9e >> >> --- >> >> configs/devices/tricore-softmmu/default.mak | 1 + >> >> hw/tricore/Kconfig | 3 +-- >> >> hw/tricore/meson.build | 4 ++-- >> >> 3 files changed, 4 insertions(+), 4 deletions(-) >> > >> > Reviewed-by: Peter Maydell >> > as far as this fix goes (though maybe CONFIG_TRICORE_TESTBOARD would b= e better?) >> > >> > But I still don't understand and would like to know: >> > (1) why doesn't CONFIG_TRICORE get set by Kconfig anyway, as >> > f4063f9c31 claims to be doing? >> >> It does (or should) thanks to meson: >> >> 'CONFIG_' + config_target['TARGET_ARCH'].to_upper() + '=3Dy' > > Yeah, but it doesn't, as you can see if you look at the meson build > log: we do pass CONFIG_TRICORE=3Dy on the minikconf command line, > but it doesn't appear in minikconf's output! > >> > (2) what are the CONFIG_$ARCH flags for? Apart from this, we >> > don't seem to be using any of them, as demonstrated by the fact >> > that nothing else broke :-) >> >> They need to be declared in Kconfig otherwise minikconf complains about >> them not being defined when you pass it in. This is part of minikconf's >> sanity checking code. > > No, I mean, if nothing anywhere in the build system is conditional > on these flags, why do we have them at all ? We know we don't > have anything that cares about them, because right now we have > a bug where they're never set... Well we have one place at the moment to ensure v7m gets included even if you don't include the various M profile boards: default y if TCG && (ARM || AARCH64) which is because translate.c still currently has a dependency on those bits. Without that you'll get a linker failure with the following build: '../../configure' '--without-default-features' '--target-list=3Darm-softm= mu,aarch64-softmmu' '--with-devices-aarch64=3Dminimal' I thought I'd added that to the build matrix but I can't find it now.=20 > > -- PMM --=20 Alex Benn=C3=A9e