* [PATCH] tests: update for rename of CentOS8 PowerTools repo
@ 2020-12-16 14:16 Daniel P. Berrangé
2020-12-16 15:23 ` Willian Rampazzo
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2020-12-16 14:16 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée,
Daniel P. Berrangé
This was intentionally renamed recently to be all lowercase:
https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
This needs to be merged asap, as CI will break for anyone whose branch
triggers a rebuild of the centos container image.
eg current broken git master:
https://gitlab.com/berrange/qemu/-/jobs/915852165
vs with this fix
https://gitlab.com/berrange/qemu/-/jobs/915862731
tests/docker/dockerfiles/centos8.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
index 54bc6d54cd..06b67962fd 100644
--- a/tests/docker/dockerfiles/centos8.docker
+++ b/tests/docker/dockerfiles/centos8.docker
@@ -31,6 +31,6 @@ ENV PACKAGES \
zlib-devel
RUN dnf install -y dnf-plugins-core && \
- dnf config-manager --set-enabled PowerTools && \
+ dnf config-manager --set-enabled powertools && \
dnf install -y $PACKAGES
RUN rpm -q $PACKAGES | sort > /packages.txt
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tests: update for rename of CentOS8 PowerTools repo
2020-12-16 14:16 [PATCH] tests: update for rename of CentOS8 PowerTools repo Daniel P. Berrangé
@ 2020-12-16 15:23 ` Willian Rampazzo
2020-12-16 16:10 ` Peter Maydell
2020-12-16 16:19 ` Alex Bennée
2 siblings, 0 replies; 6+ messages in thread
From: Willian Rampazzo @ 2020-12-16 15:23 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé,
qemu-devel
On Wed, Dec 16, 2020 at 11:21 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> This was intentionally renamed recently to be all lowercase:
>
> https://bugs.centos.org/view.php?id=17920
> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> This needs to be merged asap, as CI will break for anyone whose branch
> triggers a rebuild of the centos container image.
>
> eg current broken git master:
>
> https://gitlab.com/berrange/qemu/-/jobs/915852165
>
> vs with this fix
>
> https://gitlab.com/berrange/qemu/-/jobs/915862731
>
> tests/docker/dockerfiles/centos8.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests: update for rename of CentOS8 PowerTools repo
2020-12-16 14:16 [PATCH] tests: update for rename of CentOS8 PowerTools repo Daniel P. Berrangé
2020-12-16 15:23 ` Willian Rampazzo
@ 2020-12-16 16:10 ` Peter Maydell
2020-12-16 16:16 ` Daniel P. Berrangé
2020-12-16 16:58 ` Mark Cave-Ayland
2020-12-16 16:19 ` Alex Bennée
2 siblings, 2 replies; 6+ messages in thread
From: Peter Maydell @ 2020-12-16 16:10 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé,
QEMU Developers
On Wed, 16 Dec 2020 at 14:21, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> This was intentionally renamed recently to be all lowercase:
>
> https://bugs.centos.org/view.php?id=17920
> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> This needs to be merged asap, as CI will break for anyone whose branch
> triggers a rebuild of the centos container image.
>
> eg current broken git master:
>
> https://gitlab.com/berrange/qemu/-/jobs/915852165
>
> vs with this fix
>
> https://gitlab.com/berrange/qemu/-/jobs/915862731
>
> tests/docker/dockerfiles/centos8.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> index 54bc6d54cd..06b67962fd 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -31,6 +31,6 @@ ENV PACKAGES \
> zlib-devel
>
> RUN dnf install -y dnf-plugins-core && \
> - dnf config-manager --set-enabled PowerTools && \
> + dnf config-manager --set-enabled powertools && \
> dnf install -y $PACKAGES
> RUN rpm -q $PACKAGES | sort > /packages.txt
I tried a test merge of this but it fails in Gitlab CI:
https://gitlab.com/qemu-project/qemu/-/jobs/916041167
#6 7.706 Error: No matching repo to modify: powertools.
#6 ERROR: executor failed running [/bin/sh -c dnf install -y
dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf
install -y $PACKAGES]: exit code: 1
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests: update for rename of CentOS8 PowerTools repo
2020-12-16 16:10 ` Peter Maydell
@ 2020-12-16 16:16 ` Daniel P. Berrangé
2020-12-16 16:58 ` Mark Cave-Ayland
1 sibling, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2020-12-16 16:16 UTC (permalink / raw)
To: Peter Maydell
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée,
QEMU Developers
On Wed, Dec 16, 2020 at 04:10:56PM +0000, Peter Maydell wrote:
> On Wed, 16 Dec 2020 at 14:21, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > This was intentionally renamed recently to be all lowercase:
> >
> > https://bugs.centos.org/view.php?id=17920
> > https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >
> > This needs to be merged asap, as CI will break for anyone whose branch
> > triggers a rebuild of the centos container image.
> >
> > eg current broken git master:
> >
> > https://gitlab.com/berrange/qemu/-/jobs/915852165
> >
> > vs with this fix
> >
> > https://gitlab.com/berrange/qemu/-/jobs/915862731
> >
> > tests/docker/dockerfiles/centos8.docker | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> > index 54bc6d54cd..06b67962fd 100644
> > --- a/tests/docker/dockerfiles/centos8.docker
> > +++ b/tests/docker/dockerfiles/centos8.docker
> > @@ -31,6 +31,6 @@ ENV PACKAGES \
> > zlib-devel
> >
> > RUN dnf install -y dnf-plugins-core && \
> > - dnf config-manager --set-enabled PowerTools && \
> > + dnf config-manager --set-enabled powertools && \
> > dnf install -y $PACKAGES
> > RUN rpm -q $PACKAGES | sort > /packages.txt
>
> I tried a test merge of this but it fails in Gitlab CI:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/916041167
>
> #6 7.706 Error: No matching repo to modify: powertools.
> #6 ERROR: executor failed running [/bin/sh -c dnf install -y
> dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf
> install -y $PACKAGES]: exit code: 1
#4 [1/4] FROM docker.io/library/centos:8.1.1911@sha256:fe8d824220415eed5477...
#4 DONE 0.0s
#5 [2/4] RUN dnf -y update
#5 CACHED
Looks like in the main repo, it is using cached container layer for
the "dnf -y update" command, and so not pulling in the new centos-release
package.
In forks where the cache is not valid, it'll really run the "dnf update"
command and see the failure.
I think if you go to
https://gitlab.com/qemu-project/qemu/container_registry
and delete the currently cached centos8 image, then all subsequent runs
will fail until this patch is merged.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests: update for rename of CentOS8 PowerTools repo
2020-12-16 16:10 ` Peter Maydell
2020-12-16 16:16 ` Daniel P. Berrangé
@ 2020-12-16 16:58 ` Mark Cave-Ayland
1 sibling, 0 replies; 6+ messages in thread
From: Mark Cave-Ayland @ 2020-12-16 16:58 UTC (permalink / raw)
To: Peter Maydell, Daniel P. Berrangé
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée,
QEMU Developers
On 16/12/2020 16:10, Peter Maydell wrote:
> On Wed, 16 Dec 2020 at 14:21, Daniel P. Berrangé <berrange@redhat.com> wrote:
>>
>> This was intentionally renamed recently to be all lowercase:
>>
>> https://bugs.centos.org/view.php?id=17920
>> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>
>> This needs to be merged asap, as CI will break for anyone whose branch
>> triggers a rebuild of the centos container image.
>>
>> eg current broken git master:
>>
>> https://gitlab.com/berrange/qemu/-/jobs/915852165
>>
>> vs with this fix
>>
>> https://gitlab.com/berrange/qemu/-/jobs/915862731
>>
>> tests/docker/dockerfiles/centos8.docker | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
>> index 54bc6d54cd..06b67962fd 100644
>> --- a/tests/docker/dockerfiles/centos8.docker
>> +++ b/tests/docker/dockerfiles/centos8.docker
>> @@ -31,6 +31,6 @@ ENV PACKAGES \
>> zlib-devel
>>
>> RUN dnf install -y dnf-plugins-core && \
>> - dnf config-manager --set-enabled PowerTools && \
>> + dnf config-manager --set-enabled powertools && \
>> dnf install -y $PACKAGES
>> RUN rpm -q $PACKAGES | sort > /packages.txt
>
> I tried a test merge of this but it fails in Gitlab CI:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/916041167
>
> #6 7.706 Error: No matching repo to modify: powertools.
> #6 ERROR: executor failed running [/bin/sh -c dnf install -y
> dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf
> install -y $PACKAGES]: exit code: 1
That's odd. Could it be that gitlab is still caching the old image here?
ATB,
Mark.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests: update for rename of CentOS8 PowerTools repo
2020-12-16 14:16 [PATCH] tests: update for rename of CentOS8 PowerTools repo Daniel P. Berrangé
2020-12-16 15:23 ` Willian Rampazzo
2020-12-16 16:10 ` Peter Maydell
@ 2020-12-16 16:19 ` Alex Bennée
2 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2020-12-16 16:19 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
Daniel P. Berrangé <berrange@redhat.com> writes:
> This was intentionally renamed recently to be all lowercase:
>
> https://bugs.centos.org/view.php?id=17920
> https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> This needs to be merged asap, as CI will break for anyone whose branch
> triggers a rebuild of the centos container image.
Your in luck, Queued to pr/161220-testing-1, thanks.
>
> eg current broken git master:
>
> https://gitlab.com/berrange/qemu/-/jobs/915852165
>
> vs with this fix
>
> https://gitlab.com/berrange/qemu/-/jobs/915862731
>
> tests/docker/dockerfiles/centos8.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> index 54bc6d54cd..06b67962fd 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -31,6 +31,6 @@ ENV PACKAGES \
> zlib-devel
>
> RUN dnf install -y dnf-plugins-core && \
> - dnf config-manager --set-enabled PowerTools && \
> + dnf config-manager --set-enabled powertools && \
> dnf install -y $PACKAGES
> RUN rpm -q $PACKAGES | sort > /packages.txt
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-16 17:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16 14:16 [PATCH] tests: update for rename of CentOS8 PowerTools repo Daniel P. Berrangé
2020-12-16 15:23 ` Willian Rampazzo
2020-12-16 16:10 ` Peter Maydell
2020-12-16 16:16 ` Daniel P. Berrangé
2020-12-16 16:58 ` Mark Cave-Ayland
2020-12-16 16:19 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).