From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v6 05/11] rules.mak: Add base-arch() rule
Date: Mon, 08 Jun 2020 11:10:28 +0100 [thread overview]
Message-ID: <87r1up7trf.fsf@linaro.org> (raw)
In-Reply-To: <20200605093256.30351-6-philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> Add a rule to return the base architecture for a QEMU target.
>
> The current list of TARGET_BASE_ARCH is:
>
> $ git grep TARGET_BASE_ARCH configure
> configure:7785:TARGET_BASE_ARCH=""
> configure:7795: TARGET_BASE_ARCH=i386
> configure:7813: TARGET_BASE_ARCH=arm
> configure:7846: TARGET_BASE_ARCH=mips
> configure:7854: TARGET_BASE_ARCH=mips
> configure:7864: TARGET_BASE_ARCH=openrisc
> configure:7871: TARGET_BASE_ARCH=ppc
> configure:7879: TARGET_BASE_ARCH=ppc
> configure:7887: TARGET_BASE_ARCH=ppc
> configure:7894: TARGET_BASE_ARCH=riscv
> configure:7900: TARGET_BASE_ARCH=riscv
> configure:7920: TARGET_BASE_ARCH=sparc
> configure:7925: TARGET_BASE_ARCH=sparc
This seems backwards. We encode the base architecture in configure.sh
because this is where we can make such distinctions. We then:
echo "TARGET_BASE_ARCH=$TARGET_BASE_ARCH" >> $config_target_mak
Precisely so the make system can know what it is for any given target.
So:
> +# base-arch
> +# Usage: $(call base-arch, target)
> +#
> +# @target: the target architecture.
> +#
> +# This macro will return the base architecture for a target.
> +#
> +# As example, $(call base-arch, aarch64) returns 'arm'.
> +base-arch = $(strip \
> + $(if $(call startwith,aarch64,$1),arm,\
> + $(if $(call startwith,arm,$1),arm,\
> + $(if $(call startwith,microblaze,$1),microblaze,\
> + $(if $(call startwith,mips,$1),mips,\
> + $(if $(call startwith,ppc,$1),ppc,\
> + $(if $(call startwith,riscv,$1),riscv,\
> + $(if $(call startwith,sh4,$1),sh4,\
> + $(if $(call startwith,sparc,$1),sparc,\
> + $(if $(call startwith,xtensa,$1),xtensa,\
> + $(if $(call strequal,x86_64,$1),i386,\
> + $1\
> + )\
> + )\
> + )\
> + )\
> + )\
> + )\
> + )\
> + )\
> + )\
> + )\
> + )
Seems like a replication of information already calculated in configure
and prone to breakage if we add a new one (or come up with some franken
architecture at a later date).
--
Alex Bennée
next prev parent reply other threads:[~2020-06-08 10:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 9:32 [PATCH v6 00/11] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-08 9:59 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-08 10:00 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-06-08 9:27 ` Wang, Wenchao
2020-06-08 15:25 ` Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 04/11] rules.mak: Add strequal() and startwith() rules Philippe Mathieu-Daudé
2020-06-05 9:32 ` [PATCH v6 05/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-06-08 10:10 ` Alex Bennée [this message]
2020-06-05 9:32 ` [PATCH v6 06/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-06-08 10:10 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 07/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-06-08 10:13 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 08/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-08 10:13 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 09/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-08 10:15 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-08 11:09 ` Alex Bennée
2020-06-05 9:32 ` [PATCH v6 11/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-08 11:08 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1up7trf.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).