From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fakx3-0004jh-4v for qemu-devel@nongnu.org; Wed, 04 Jul 2018 12:48:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fakx0-0007jk-IA for qemu-devel@nongnu.org; Wed, 04 Jul 2018 12:48:21 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:37040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fakx0-0007hS-9n for qemu-devel@nongnu.org; Wed, 04 Jul 2018 12:48:18 -0400 Received: by mail-wm0-x243.google.com with SMTP id n17-v6so6837503wmh.2 for ; Wed, 04 Jul 2018 09:48:18 -0700 (PDT) References: <20180703151732.29843-1-richard.henderson@linaro.org> <87y3er84ud.fsf@linaro.org> <87woub80yh.fsf@linaro.org> <36142D7E-604F-428F-BF51-4AE9DC64FC0B@gmail.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <36142D7E-604F-428F-BF51-4AE9DC64FC0B@gmail.com> Date: Wed, 04 Jul 2018 17:48:15 +0100 Message-ID: <87r2kj7xrk.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Richard Henderson , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Programmingkid writes: >> On Jul 4, 2018, at 11:39 AM, Alex Benn=C3=A9e w= rote: >> >> >> Programmingkid writes: >> >>>> On Jul 4, 2018, at 10:15 AM, Alex Benn=C3=A9e = wrote: >>>> >>>> >>>> Richard Henderson writes: >>>> >>>>> >>>>> Anyway, all of this has been broken long enough that it'll need to >>>>> wait til next devel cycle before anything further gets done. >>>> >>>> When it gets done should we add some explicit ppc tests to tests/tcg/p= pc >>>> like we did with arm64 fcvt or would it be worth spending more time on >>>> the general purpose FP test suite Emilio was working on as part of his >>>> hard-float series? >>> >>> My vote goes to adding PowerPC specific tests. I already made some and = sent them to the list a couple of days ago. A general purpose floating poin= t test suite would probably not be able to test things like PowerPC floatin= g point flags. >>> >>> I'm not certain how we would add floating point tests to QEMU. I'm >>> guessing it would involve some kind of bootable image file that would >>> load and run the tests. Hopefully there is an easier way to implement >>> testing. >> >> You don't need system tests - this is all testable from linux-user. See >> tests/tcg/arm/fcvt.c and the .ref files in arm and aarch64 directories. >> Assuming the test isn't insane (like test-i386-fprem) we can just add a >> reference output recorded on know good hardware. > > My hope is to make testing the floating point unit as easy as 'make > test' or maybe 'make fp-test'. That would be "make check-tcg" -- Alex Benn=C3=A9e