From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQ7Xf-00077l-7h for qemu-devel@nongnu.org; Wed, 28 Jun 2017 03:37:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQ7Xe-0007QI-GP for qemu-devel@nongnu.org; Wed, 28 Jun 2017 03:37:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51466) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dQ7Xe-0007QA-B2 for qemu-devel@nongnu.org; Wed, 28 Jun 2017 03:37:38 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57BA37CE02 for ; Wed, 28 Jun 2017 07:37:37 +0000 (UTC) From: Juan Quintela In-Reply-To: <1498634144-26508-1-git-send-email-peterx@redhat.com> (Peter Xu's message of "Wed, 28 Jun 2017 15:15:44 +0800") References: <1498634144-26508-1-git-send-email-peterx@redhat.com> Reply-To: quintela@redhat.com Date: Wed, 28 Jun 2017 09:37:34 +0200 Message-ID: <87r2y47ebl.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v6 11/10] migration: add comment for TYPE_MIGRATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, lvivier@redhat.com, eblake@redhat.com, armbru@redhat.com, dgilbert@redhat.com Peter Xu wrote: > It'll be strange that the migration object inherits TYPE_DEVICE. Add > some explanations to it. > > Signed-off-by: Peter Xu > --- > migration/migration.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/migration/migration.c b/migration/migration.c > index b1b0825..2398a9d 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2046,6 +2046,14 @@ static void migration_instance_init(Object *obj) > > static const TypeInfo migration_type = { > .name = TYPE_MIGRATION, > + /* > + * NOTE: "migration" itself is not really a device. We used > + * TYPE_DEVICE here only to leverage some existing QDev features > + * like "-global" properties, and HW_COMPAT_* fields (which are > + * finally applied as global properties as well). If one day the > + * global property feature can be migrated from QDev to QObject in > + * general, then we can switch to QObject as well. > + */ > .parent = TYPE_DEVICE, > .class_init = migration_class_init, > .class_size = sizeof(MigrationClass), Reviewed-by: Juan Quintela