From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFzUw-0003S4-QC
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:56:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFzUv-0000Fe-V4
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:56:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34885)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bFzUv-0000FV-Pd
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:56:25 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 4F041C003555
	for <qemu-devel@nongnu.org>; Thu, 23 Jun 2016 07:56:25 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1466437983-27133-1-git-send-email-ehabkost@redhat.com>
	<1466437983-27133-7-git-send-email-ehabkost@redhat.com>
Date: Thu, 23 Jun 2016 09:56:23 +0200
In-Reply-To: <1466437983-27133-7-git-send-email-ehabkost@redhat.com> (Eduardo
	Habkost's message of "Mon, 20 Jun 2016 12:52:59 -0300")
Message-ID: <87r3bo5oew.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 06/10] vl: Set errp to &error_abort on
 machine compat_props
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

Eduardo Habkost <ehabkost@redhat.com> writes:

> Use the new GlobalProperty.errp field to handle compat_props
> errors.
>
> Example output before this change:
> (with an intentionally broken entry added to PC_COMPAT_1_3 just
> for testing)
>
>   $ qemu-system-x86_64 -machine pc-1.3
>   qemu-system-x86_64: hw/core/qdev-properties.c:1091: qdev_prop_set_globals_for_type: Assertion `prop->user_provided' failed.
>   Aborted (core dumped)
>
> After:
>
>   $ qemu-system-x86_64 -machine pc-1.3
>   Unexpected error in x86_cpuid_set_vendor() at /home/ehabkost/rh/proj/virt/qemu/target-i386/cpu.c:1688:
>   qemu-system-x86_64: can't apply global cpu.vendor=x: Property '.vendor' doesn't take value 'x'
>   Aborted (core dumped)
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>