From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aZJCM-0005ot-TH
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 09:16:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aZJCI-0004s2-Sh
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 09:16:50 -0500
Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:38255)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aZJCI-0004rs-Cs
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 09:16:46 -0500
Received: by mail-wm0-x229.google.com with SMTP id a4so71750227wme.1
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2016 06:16:46 -0800 (PST)
References: <1456492533-17171-1-git-send-email-alex.bennee@linaro.org>
	<1456492533-17171-2-git-send-email-alex.bennee@linaro.org>
	<20160226140419.7g2y4tleti5sysk4@hawk.localdomain>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <20160226140419.7g2y4tleti5sysk4@hawk.localdomain>
Date: Fri, 26 Feb 2016 14:16:43 +0000
Message-ID: <87r3fz7e0k.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC 01/11] config/config-arm-common: build-up
	tests-common target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: mttcg@greensocs.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, will.deacon@arm.com, qemu-devel@nongnu.org, crosthwaitepeter@gmail.com, pbonzini@redhat.com, rth@twiddle.net, aurelien@aurel32.net, fred.konrad@greensocs.com


Andrew Jones <drjones@redhat.com> writes:

> On Fri, Feb 26, 2016 at 01:15:23PM +0000, Alex Bennée wrote:
>> This is a source of needless conflicts when adding new tests and
>> re-basing. Let's just build up the lists of tests by hand.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  config/config-arm-common.mak | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/config/config-arm-common.mak b/config/config-arm-common.mak
>> index 698555d..e037507 100644
>> --- a/config/config-arm-common.mak
>> +++ b/config/config-arm-common.mak
>> @@ -9,9 +9,8 @@ ifeq ($(LOADADDR),)
>>  	LOADADDR = 0x40000000
>>  endif
>>
>> -tests-common = \
>> -	$(TEST_DIR)/selftest.flat \
>> -	$(TEST_DIR)/spinlock-test.flat
>> +tests-common = $(TEST_DIR)/selftest.flat
>> +tests-common += $(TEST_DIR)/spinlock-test.flat
>>
>>  all: test_cases
>>
>> --
>> 2.7.1
>>
>>
>
> I agree with this patch, but we could probably just squash it
> with the addition of the next test.

It was originally but during yet-another-rebase I thought I'd just
separate the patch so it wasn't dependant on what was merged next!

>
> drew


--
Alex Bennée