From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorHK-00055p-9T for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:05:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XorHF-0000Ux-Go for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:05:26 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:39281 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XorHF-0000U8-Au for qemu-devel@nongnu.org; Thu, 13 Nov 2014 05:05:21 -0500 References: <1415751963-4081-1-git-send-email-greg.bellows@linaro.org> <1415751963-4081-8-git-send-email-greg.bellows@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1415751963-4081-8-git-send-email-greg.bellows@linaro.org> Date: Thu, 13 Nov 2014 10:05:22 +0000 Message-ID: <87r3x7h0v1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v1 07/15] android-console: Init the battery ID state field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Bellows Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, christoffer.dall@linaro.org Greg Bellows writes: > Adds initialization of the battery ID field so that it is discoverable by name > (ID) when needed by power commands. > > Signed-off-by: Greg Bellows > --- > hw/misc/goldfish_battery.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/misc/goldfish_battery.c b/hw/misc/goldfish_battery.c > index a0bc379..11a2561 100644 > --- a/hw/misc/goldfish_battery.c > +++ b/hw/misc/goldfish_battery.c > @@ -141,6 +141,11 @@ static void goldfish_battery_realize(DeviceState *dev, Error **errp) > SysBusDevice *sbdev = SYS_BUS_DEVICE(dev); > struct goldfish_battery_state *s = GOLDFISH_BATTERY(dev); > > + /* Initialize the device ID so the battery can be looked up during monitor > + * commands. > + */ > + dev->id = strdup("goldfish_battery"); > + We should probably use g_strdup() here. > memory_region_init_io(&s->iomem, OBJECT(s), &goldfish_battery_iomem_ops, s, > "goldfish_battery", 0x1000); > sysbus_init_mmio(sbdev, &s->iomem); -- Alex Bennée