From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VshYl-0003XX-5b for qemu-devel@nongnu.org; Mon, 16 Dec 2013 18:26:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VshYf-0005ce-A7 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 18:26:47 -0500 Received: from mail-pb0-f45.google.com ([209.85.160.45]:54533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VshYf-0005ca-1G for qemu-devel@nongnu.org; Mon, 16 Dec 2013 18:26:41 -0500 Received: by mail-pb0-f45.google.com with SMTP id rp16so6137874pbb.32 for ; Mon, 16 Dec 2013 15:26:40 -0800 (PST) From: Anthony Liguori In-Reply-To: <1386938688-22433-1-git-send-email-imammedo@redhat.com> References: <1386938688-22433-1-git-send-email-imammedo@redhat.com> Date: Mon, 16 Dec 2013 15:26:37 -0800 Message-ID: <87r49c1ioi.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, ehabkost@redhat.com, mst@redhat.com, marcel.a@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, dkoch@verizon.co, pbonzini@redhat.com, afaerber@suse.de Igor Mammedov writes: > changes since v2: > * s/hotplugable/hotpluggable/ > * move hotplug check to an earlier patch: > "qdev: add "hotpluggable" property to Device" > -- > Refactor PCI specific hotplug API to a more generic/reusable one. > Model it after SCSI-BUS like hotplug API replacing single hotplug > callback with hotplug/hot_unplug pair of callbacks as suggested by > Paolo. > Difference between SCSI-BUS and this approach is that the former > is BUS centric while the latter is device centred. Which is evolved > from the fact that hotplug callbacks used by ACPI/SHPC/PCIE are > implemented by devices rather than by bus and bus serves only as > a proxy to forward event to hotplug device. > Memory hotplug also exposes tha same usage pattern hence an attempt > to generalize hotplug API. > > Refactoring also simplifies wiring of a hotplug device with a bus, > all it needs is to set "hotplug-device" link on bus, which > would potentially allow to do it from configuration file, > there is not need to setup hotplug device callbacks on bus > synce it can get them via HOTPLUG_DEVICE API of "hotplug-device" > target. > > In addition device centred hotplug API may be used by bus-less > hotplug implementations as well if it's decided to use > link instead of bus. I'm having a hard time parsing this description. Sharing hot plug code is a good thing. Making hotplug a qdev-level concept seems like a bad thing to me. The series is a net add of code so I don't think we're winning anything by generalizing here. Is there a use-case this enables that isn't possible today? Regards, Anthony Liguori > > Patches 8-11 are should be merged as one and are split only for > simplifying review (they compile fine but PCI hotplug is broken > until the last patch is applyed). > > git tree for testing: > https://github.com/imammedo/qemu/commits/hotplug_dev_inf_v3 > > tested only ACPI and PCIE hotplug. > > Herv=C3=A9 Poussineau (1): > qom: detect bad reentrance during object_class_foreach > > Igor Mammedov (9): > define hotplug interface > qdev: add to BusState "hotplug-handler" link > qdev: add "hotpluggable" property to Device > hw/acpi: move typeinfo to the file end > qdev:pci: refactor PCIDevice to use generic "hotpluggable" property > acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API > pci/shpc: convert SHPC hotplug to use hotplug-handler API > pci/pcie: convert PCIE hotplug to use hotplug-handler API > hw/pci: switch to a generic hotplug handling for PCIDevice > > Paolo Bonzini (1): > qom: do not register interface "types" in the type table > > hw/acpi/piix4.c | 151 ++++++++++++++++++++++-------------= ------ > hw/core/Makefile.objs | 1 + > hw/core/hotplug.c | 48 +++++++++++++ > hw/core/qdev.c | 50 ++++++++++++-- > hw/display/cirrus_vga.c | 2 +- > hw/display/qxl.c | 2 +- > hw/display/vga-pci.c | 2 +- > hw/display/vmware_vga.c | 2 +- > hw/i386/acpi-build.c | 6 +- > hw/ide/piix.c | 4 +- > hw/isa/piix4.c | 2 +- > hw/pci-bridge/pci_bridge_dev.c | 9 +++ > hw/pci-host/piix.c | 6 +- > hw/pci/pci.c | 40 +---------- > hw/pci/pcie.c | 73 +++++++++++++------- > hw/pci/pcie_port.c | 8 +++ > hw/pci/shpc.c | 133 +++++++++++++++++++++++------------- > hw/usb/hcd-ehci-pci.c | 2 +- > hw/usb/hcd-ohci.c | 2 +- > hw/usb/hcd-uhci.c | 2 +- > hw/usb/hcd-xhci.c | 2 +- > include/hw/hotplug.h | 75 ++++++++++++++++++++ > include/hw/pci/pci.h | 13 ---- > include/hw/pci/pci_bus.h | 2 - > include/hw/pci/pcie.h | 5 ++ > include/hw/pci/shpc.h | 8 +++ > include/hw/qdev-core.h | 8 +++ > qom/object.c | 17 ++++- > 28 files changed, 455 insertions(+), 220 deletions(-) > create mode 100644 hw/core/hotplug.c > create mode 100644 include/hw/hotplug.h > > --=20 > 1.8.3.1