From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqrqy-00016H-DO for qemu-devel@nongnu.org; Wed, 11 Dec 2013 17:02:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqrqt-0007M0-D2 for qemu-devel@nongnu.org; Wed, 11 Dec 2013 17:02:00 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:48680 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqrqt-0007Lt-6k for qemu-devel@nongnu.org; Wed, 11 Dec 2013 17:01:55 -0500 References: <1386612744-1013-1-git-send-email-peter.maydell@linaro.org> <1386612744-1013-5-git-send-email-peter.maydell@linaro.org> <52A6318B.4070609@twiddle.net> <87siu06bbp.fsf@linaro.org> <52A73A5F.4050101@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <52A73A5F.4050101@twiddle.net> Date: Wed, 11 Dec 2013 22:01:49 +0000 Message-ID: <87r49jnj1u.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 4/9] target-arm: A64: add support for ld/st with reg offset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Peter Maydell , patches@linaro.org, Michael Matz , qemu-devel@nongnu.org, Claudio Fontana , Dirk Mueller , Will Newton , Laurent Desnogues , Alex =?utf-8?Q?Benn=C3=A9e?= , kvmarm@lists.cs.columbia.edu, Christoffer Dall rth@twiddle.net writes: > On 12/10/2013 06:16 AM, Alex Bennée wrote: >> However my preference unless there is a strong objection would be to >> clean that up in later patches. For one thing the more instructions each >> patch handles the longer it takes to run the instruction validation on >> the rather slow models to have good coverage of the decoder! > > That'd be ok by me. I had a play trying to see what pulling out the common parts of decode and unallocated handling based on the ARM ARM pseudo-code into a separate function would look like. Unfortunately what I ended up with was a horrible function full of pass-by-reference parameters and a not particularly cleaner or shorter call-sites in each handler. I did briefly consider if I could construct a macro which would make for less duplicated code but suspect that won't help in the long run. This is certainly something I think that requires more thought. In the meantime I've addresses your other review comments and Peter should be pushing a new set of patches soon. Cheers, -- Alex Bennée QEMU/KVM Hacker for Linaro