Re: [Qemu-devel] [PATCH] 9p: Be robust against paths without FS_IOC_GETVERSION

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Gabriel de Perthuis <g2p.code@gmail.com> writes:

> The current implementation checked for supported filesystems at mount
> time, but actual support depends on the path.  Don't error out when
> finding unversioned paths.

Can you elaborate this a bit ?

>
> This fix allows booting a linux kernel with the same / filesystem as the
> host; otherwise the boot fails when mounting devtmpfs.
>
> Signed-off-by: Gabriel de Perthuis <g2p.code@gmail.com>
> ---
>  hw/9pfs/cofile.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/hw/9pfs/cofile.c b/hw/9pfs/cofile.c
> index 2efebf3..194c130 100644
> --- a/hw/9pfs/cofile.c
> +++ b/hw/9pfs/cofile.c
> @@ -36,10 +36,14 @@ int v9fs_co_st_gen(V9fsPDU *pdu, V9fsPath *path, mode_t st_mode,
>                      err = -errno;
>                  }
>              });
>          v9fs_path_unlock(s);
>      }
> +    /* The ioctl may not be supported depending on the path */
> +    if (err == -ENOTTY) {
> +        err = 0;
> +    }

So you don't want to consider -ENOTTY as an error ? why ?

>      return err;
>  }
>
>  int v9fs_co_lstat(V9fsPDU *pdu, V9fsPath *path, struct stat *stbuf)
>  {
> -- 

-aneesh