From: Anthony Liguori <anthony@codemonkey.ws>
To: Laszlo Ersek <lersek@redhat.com>, mst@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 5/7] hw/acpi: export acpi_checksum()
Date: Thu, 25 Apr 2013 13:55:21 -0500 [thread overview]
Message-ID: <87r4hyxwx2.fsf@codemonkey.ws> (raw)
In-Reply-To: <1366316544-1428-6-git-send-email-lersek@redhat.com>
Laszlo Ersek <lersek@redhat.com> writes:
> Again, this enables reuse when preparing per-table fw_cfg blobs later.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
> ---
> include/hw/acpi/acpi.h | 2 ++
> hw/acpi/core.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
> index bc7e107..7e51110 100644
> --- a/include/hw/acpi/acpi.h
> +++ b/include/hw/acpi/acpi.h
> @@ -180,4 +180,6 @@ typedef struct acpi_table_std_header {
> } QEMU_PACKED AcpiTableStdHdr;
>
> extern const AcpiTableStdHdr acpi_dfl_hdr;
> +
> +int acpi_checksum(const uint8_t *data, int len);
> #endif /* !QEMU_HW_ACPI_H */
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index 36a4d03..3be7e09 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -69,7 +69,7 @@ static void acpi_register_config(void)
>
> machine_init(acpi_register_config);
>
> -static int acpi_checksum(const uint8_t *data, int len)
> +int acpi_checksum(const uint8_t *data, int len)
> {
> int sum, i;
> sum = 0;
> --
> 1.7.1
next prev parent reply other threads:[~2013-04-25 18:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 20:22 [Qemu-devel] [PATCH v4 0/7] publish etc/acpi/APIC in fw_cfg Laszlo Ersek
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 1/7] refer to FWCfgState explicitly Laszlo Ersek
2013-04-25 18:44 ` Anthony Liguori
2013-04-25 21:04 ` Michael S. Tsirkin
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 2/7] acpi_table_install(): fix funcparam formatting in leading comment Laszlo Ersek
2013-04-25 18:44 ` Anthony Liguori
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 3/7] hw/acpi: extract standard table headers as a standalone structure Laszlo Ersek
2013-04-25 18:47 ` Anthony Liguori
2013-04-26 9:32 ` Laszlo Ersek
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 4/7] hw/acpi: export default ACPI headers using the type just introduced Laszlo Ersek
2013-04-25 18:49 ` Anthony Liguori
2013-04-26 9:53 ` Laszlo Ersek
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 5/7] hw/acpi: export acpi_checksum() Laszlo Ersek
2013-04-25 18:55 ` Anthony Liguori [this message]
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 6/7] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h Laszlo Ersek
2013-04-25 18:55 ` Anthony Liguori
2013-04-18 20:22 ` [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients Laszlo Ersek
2013-04-18 20:30 ` Michael S. Tsirkin
2013-04-19 10:58 ` Laszlo Ersek
2013-04-24 9:42 ` Michael S. Tsirkin
2013-04-25 19:03 ` Anthony Liguori
2013-04-25 20:11 ` Eduardo Habkost
2013-04-25 20:45 ` Anthony Liguori
2013-04-25 20:57 ` [Qemu-devel] Purpose of qemu-common.h (was Re: [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients) Eduardo Habkost
2013-04-25 21:33 ` Michael S. Tsirkin
2013-04-26 11:13 ` [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients Laszlo Ersek
2013-04-29 8:20 ` Michael S. Tsirkin
2013-04-29 12:39 ` Kevin O'Connor
2013-04-29 13:21 ` Michael S. Tsirkin
2013-04-29 13:21 ` Laszlo Ersek
2013-04-24 9:39 ` [Qemu-devel] [PATCH v4 0/7] publish etc/acpi/APIC in fw_cfg Laszlo Ersek
2013-04-25 16:45 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4hyxwx2.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).