Re: [Qemu-devel] [PATCH] chardev: add vte chardev

[Anthony Liguori <aliguori@us.ibm.com>]

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>>> Also:  Once I'm done with the console cleanup it will be easy to make
>>> 'vc' actually work with gtk.
>> 
>> Please no.  'vc' needs to die.  I don't want anyone using it...
>
> Likewise easy.
>
>>>> 'vc' is a graphical chardev and it should be up to what UI layer to
>>>> decide how to express it
>>>
>>> No.
>>>
>>> 'vc' is a DisplaySurface filled by the qemu terminal emulation.  It's
>>> generic and works with any UI.
>> 
>> QEMU shouldn't be in the terminal emulation business.
>
> Well, it already is.  Not that I want extend it or would recommend using
> it if there are better options.  But there is no reason to break it, and
> it is useful to me now and then.

qemu -display sdl -vnc :1 -serial vc

Continues to do what it did before.

qemu -display gtk -vnc :1 -serial vc

Seg faults which is bad.  I can look more deeply into that.

But with your proposal, the above would either (1) use the old style
console in GTK or (2) not make the console available in gtk.

Both are bad because they have consequences for:

qemu -serial vc

The above must continue to have a reasonable behavior by default and
with GTK as the default, that means using VTE as the terminal emulation.

If you can find a way to make 'qemu -display gtk -vnc :1 -serial vc'
behave without impacting the other use-cases, I'm open to that but just
renaming 'vc' to 'vte' for gtk is going to be a compat breaker.

Regards,

Anthony Liguori

>
> cheers,
>   Gerd