From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFpST-0006kE-Ev for qemu-devel@nongnu.org; Wed, 13 Mar 2013 13:27:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFpSR-0001pp-Va for qemu-devel@nongnu.org; Wed, 13 Mar 2013 13:27:21 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:60417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFpSR-0001pO-Ds for qemu-devel@nongnu.org; Wed, 13 Mar 2013 13:27:19 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 14 Mar 2013 03:21:04 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 02E702CE804C for ; Thu, 14 Mar 2013 04:27:15 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2DHEJFI3735948 for ; Thu, 14 Mar 2013 04:14:20 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2DHRDc8004517 for ; Thu, 14 Mar 2013 04:27:13 +1100 From: Anthony Liguori In-Reply-To: <5140AA47.5020209@redhat.com> References: <1363169922-24335-1-git-send-email-kraxel@redhat.com> <87k3pbiiur.fsf@codemonkey.ws> <51408C70.7010603@redhat.com> <87wqtbnvd7.fsf@codemonkey.ws> <5140AA47.5020209@redhat.com> Date: Wed, 13 Mar 2013 12:27:10 -0500 Message-ID: <87r4jjrz0x.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] chardev: add vte chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > Hi, > >>> Also: Once I'm done with the console cleanup it will be easy to make >>> 'vc' actually work with gtk. >> >> Please no. 'vc' needs to die. I don't want anyone using it... > > Likewise easy. > >>>> 'vc' is a graphical chardev and it should be up to what UI layer to >>>> decide how to express it >>> >>> No. >>> >>> 'vc' is a DisplaySurface filled by the qemu terminal emulation. It's >>> generic and works with any UI. >> >> QEMU shouldn't be in the terminal emulation business. > > Well, it already is. Not that I want extend it or would recommend using > it if there are better options. But there is no reason to break it, and > it is useful to me now and then. qemu -display sdl -vnc :1 -serial vc Continues to do what it did before. qemu -display gtk -vnc :1 -serial vc Seg faults which is bad. I can look more deeply into that. But with your proposal, the above would either (1) use the old style console in GTK or (2) not make the console available in gtk. Both are bad because they have consequences for: qemu -serial vc The above must continue to have a reasonable behavior by default and with GTK as the default, that means using VTE as the terminal emulation. If you can find a way to make 'qemu -display gtk -vnc :1 -serial vc' behave without impacting the other use-cases, I'm open to that but just renaming 'vc' to 'vte' for gtk is going to be a compat breaker. Regards, Anthony Liguori > > cheers, > Gerd