From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TStC4-0007AS-Na
	for qemu-devel@nongnu.org; Mon, 29 Oct 2012 13:32:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TStC0-0002BT-K1
	for qemu-devel@nongnu.org; Mon, 29 Oct 2012 13:32:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TStC0-0002BP-Ak
	for qemu-devel@nongnu.org; Mon, 29 Oct 2012 13:32:04 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9THW3ZX027409
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 29 Oct 2012 13:32:03 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <87objlp97t.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Mon, 29 Oct 2012 16:51:50 +0100")
References: <1351519903-26607-1-git-send-email-quintela@redhat.com>
	<1351519903-26607-8-git-send-email-quintela@redhat.com>
	<87objlp97t.fsf@blackfin.pond.sub.org>
Date: Mon, 29 Oct 2012 18:32:00 +0100
Message-ID: <87r4ohkwvj.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: owasserm@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, avi@redhat.com

Markus Armbruster <armbru@redhat.com> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> Move all the writes to the migration_thread, and make writings
>> blocking.  Notice that are still using the iothread for everything
>> that we do.
> [...]
>> diff --git a/qemu-sockets.c b/qemu-sockets.c
>> index cfed9c5..61b6e95 100644
>> --- a/qemu-sockets.c
>> +++ b/qemu-sockets.c
>> @@ -276,9 +276,6 @@ static int inet_connect_addr(struct addrinfo *addr, bool *in_progress,
>>          return -1;
>>      }
>>      qemu_setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
>> -    if (connect_state != NULL) {
>> -        socket_set_nonblock(sock);
>> -    }
>>      /* connect to peer */
>>      do {
>>          rc = 0;
>> @@ -732,7 +729,6 @@ int unix_connect_opts(QemuOpts *opts, Error **errp,
>>          connect_state = g_malloc0(sizeof(*connect_state));
>>          connect_state->callback = callback;
>>          connect_state->opaque = opaque;
>> -        socket_set_nonblock(sock);
>>      }
>>
>>      memset(&un, 0, sizeof(un));
>
> Doesn't this break inet_nonblocking_connect() and
> unix_nonblocking_connect()?
>
> In your cover letter, you wrote:
>
>     Note: Writes has become blocking, and I have to change the "remove"
>     the feature now in qemu-sockets.c.  Checked that migration was the
>     only user of that feature.  If new users appear, they just need to add
>     the socket_set_nonblock() by hand.
>
> Yes, migration-{tcp,unix} are their only users, but if they want a
> blocking socket now, why not use inet_connect() and unix_connect()?
>
> New users can't "just add socket_set_nonblock()".  They'd have to add it
> right where you deleted it: between qemu_socket() and connect().  Else
> the connect() is blocking.

Grrr.

So, is there any way to make a connection that is non-blocking, but then
writes are blocking?

Later, Juan.