From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDg0Z-0005RK-UG for qemu-devel@nongnu.org; Mon, 17 Sep 2012 14:25:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDg0V-000374-Hy for qemu-devel@nongnu.org; Mon, 17 Sep 2012 14:25:23 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:49336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDg0V-00036c-EA for qemu-devel@nongnu.org; Mon, 17 Sep 2012 14:25:19 -0400 Received: from /spool/local by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Sep 2012 14:25:18 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8HIPG5K130792 for ; Mon, 17 Sep 2012 14:25:16 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8HIPFPh027277 for ; Mon, 17 Sep 2012 14:25:15 -0400 From: Anthony Liguori In-Reply-To: <504F4CE1.7020405@siemens.com> References: <504F4CE1.7020405@siemens.com> Date: Mon, 17 Sep 2012 13:25:11 -0500 Message-ID: <87r4q04id4.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , qemu-devel Cc: Julien Grall , Stefano Stabellini , =?utf-8?Q?Herv=C3=A9?= Poussineau , Avi Kivity , Gerd Hoffmann Jan Kiszka writes: > We have debugcon these days to listen on those ports that receive debug > messages. Also drop the others that have no effect anymore. > > Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori > --- > hw/pc.c | 27 --------------------------- > 1 files changed, 0 insertions(+), 27 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index 112739a..7e7e0e2 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -53,9 +53,6 @@ > #include "bitmap.h" > #include "vga-pci.h" > > -/* output Bochs bios info messages */ > -//#define DEBUG_BIOS > - > /* debug PC/ISA interrupts */ > //#define DEBUG_IRQ > > @@ -534,17 +531,6 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) > static int shutdown_index = 0; > > switch(addr) { > - /* Bochs BIOS messages */ > - case 0x400: > - case 0x401: > - /* used to be panic, now unused */ > - break; > - case 0x402: > - case 0x403: > -#ifdef DEBUG_BIOS > - fprintf(stderr, "%c", val); > -#endif > - break; > case 0x8900: > /* same as Bochs power off */ > if (val == shutdown_str[shutdown_index]) { > @@ -558,16 +544,9 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) > } > break; > > - /* LGPL'ed VGA BIOS messages */ > case 0x501: > case 0x502: > exit((val << 1) | 1); > - case 0x500: > - case 0x503: > -#ifdef DEBUG_BIOS > - fprintf(stderr, "%c", val); > -#endif > - break; > } > } > > @@ -596,17 +575,11 @@ static void *bochs_bios_init(void) > uint64_t *numa_fw_cfg; > int i, j; > > - register_ioport_write(0x400, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x401, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x402, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x403, 1, 1, bochs_bios_write, NULL); > register_ioport_write(0x8900, 1, 1, bochs_bios_write, NULL); > > register_ioport_write(0x501, 1, 1, bochs_bios_write, NULL); > register_ioport_write(0x501, 1, 2, bochs_bios_write, NULL); > register_ioport_write(0x502, 1, 2, bochs_bios_write, NULL); > - register_ioport_write(0x500, 1, 1, bochs_bios_write, NULL); > - register_ioport_write(0x503, 1, 1, bochs_bios_write, NULL); > > fw_cfg = fw_cfg_init(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 1, 0, 0); > > -- > 1.7.3.4