From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1kVm-0002sN-Up for qemu-devel@nongnu.org; Wed, 15 Aug 2012 16:48:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1kVl-0007rE-Qf for qemu-devel@nongnu.org; Wed, 15 Aug 2012 16:48:18 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:58771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1kVl-0007r5-Kb for qemu-devel@nongnu.org; Wed, 15 Aug 2012 16:48:17 -0400 Received: by obbta14 with SMTP id ta14so2429453obb.4 for ; Wed, 15 Aug 2012 13:48:16 -0700 (PDT) From: Anthony Liguori In-Reply-To: <87sjbn524v.fsf@blackfin.pond.sub.org> References: <1345058260-16229-1-git-send-email-armbru@redhat.com> <3D70C0B4-9832-40AE-9DED-1A92E92F9192@suse.de> <87ehn8rkp4.fsf@codemonkey.ws> <87sjbn524v.fsf@blackfin.pond.sub.org> Date: Wed, 15 Aug 2012 15:48:13 -0500 Message-ID: <87r4r77ugi.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , Evgeny Voevodin , qemu-devel@nongnu.org, Peter Crosthwaite , Max Filippov , "Edgar E. Iglesias" , Guan Xuetao , Igor Mitsyanko , Alexander Graf , Andreas =?utf-8?Q?F=C3=A4rber?= , =?utf-8?Q?Herv=C3=A9?= Poussineau , Maksim Kozlov , Stefano Stabellini , Jan Kiszka , Paul Brook , Blue Swirl , Mark Langsdorf , Michael Walle , qemu-ppc@nongnu.org, Dmitry Solodkiy , Peter Chubb , Aurelien Jarno Markus Armbruster writes: > Anthony Liguori writes: > >> Peter Maydell writes: >> >>> On 15 August 2012 20:25, Alexander Graf wrote: >>>> On 15.08.2012, at 21:17, Markus Armbruster wrote: >>>> >>>>> We create a number of default drives for machines to use: floppy, >>>>> CD-ROM, SD card. Machines can suppress the ones they don't use, but >>>>> few do. Fix that. >>> >>>>> v2: >>>>> Make default drives opt-in instead of opt-out for boards (Andreas) >>>>> Cover new target unicore32 >>>>> Bonus fix for unicore32 -M puv3 without -kernel >>>>> Cover mpc8544ds, pseries (missed in v1) >>>> >>>> Nack from my POV. Too late for 1.2. Better get this in early for 1.3. > > What's the risk? > > For the record, I tested every single machine to make sure it still gets > default drives for any drive it uses. > >> No, it's not too late for 1.2. >> >> The release process is pretty clear. Major features needed to be posted >> before August 1st. The late to get non-bug fixes in is today. >> >> This is not a major feature but more importantly, has gone through a few >> revisions and has gotten positive review comments. >> >> So let's not just go around declaring things as being "too late". If >> something needs more review or hasn't gotten adequate review, it's >> perfectly acceptable to point that out. But please don't just Nack and >> say it's too late. >> >>> Agree. I also think we should follow up Paul Brook's suggestion >>> that we don't need to have any kind of "default sd card" flag >>> at all. Floppy is weird because we don't properly separate out >>> the drive and the controller, right? Not sure about cdrom... >> >> This is a valid critique and suggests that more review is needed. >> Given that, I won't pick this up today. But let's not throw around >> Nacks without justification. > > Paul's idea is worth pursuing. But I don't think we should reject a > improvement we can have now just we can imagine an even nicer > improvement we may have some day. Taking the former now doesn't make > the latter any harder. If doing it a different way means touching 50 files again, then it's best not to rush into that. There is something to be said to for avoiding unnecessary churn. Regards, Anthony Liguori