From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0qYa-0006Z7-Ia for qemu-devel@nongnu.org; Fri, 24 Feb 2012 03:31:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0qYS-0007PG-2J for qemu-devel@nongnu.org; Fri, 24 Feb 2012 03:31:11 -0500 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:40589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0qYR-0007Oz-Ds for qemu-devel@nongnu.org; Fri, 24 Feb 2012 03:31:04 -0500 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 Feb 2012 14:00:59 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1O8UCNK4088014 for ; Fri, 24 Feb 2012 14:00:12 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1O8UBBI017745 for ; Fri, 24 Feb 2012 19:30:12 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <1330043012-30556-5-git-send-email-david@gibson.dropbear.id.au> References: <1330043012-30556-1-git-send-email-david@gibson.dropbear.id.au> <1330043012-30556-5-git-send-email-david@gibson.dropbear.id.au> Date: Fri, 24 Feb 2012 13:59:57 +0530 Message-ID: <87r4xkiqgq.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 4/6] Endian fixes for virtfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , anthony@codemonkey.ws Cc: qemu-devel@nongnu.org On Fri, 24 Feb 2012 11:23:30 +1100, David Gibson wrote: > From: Benjamin Herrenschmidt > > This patch fixes several endian bugs in virtfs. > > Cc: Aneesh Kumar K.V > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: David Gibson > --- > hw/9pfs/virtio-9p.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index a72ffc3..c633fb9 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -1349,7 +1349,9 @@ static void v9fs_open(void *opaque) > if (s->proto_version == V9FS_PROTO_2000L) { > err = pdu_unmarshal(pdu, offset, "dd", &fid, &mode); > } else { > - err = pdu_unmarshal(pdu, offset, "db", &fid, &mode); > + uint8_t modebyte; > + err = pdu_unmarshal(pdu, offset, "db", &fid, &modebyte); > + mode = modebyte; > } > if (err < 0) { > goto out_nofid; > @@ -3260,9 +3262,9 @@ void handle_9p_output(VirtIODevice *vdev, VirtQueue *vq) > > ptr = pdu->elem.out_sg[0].iov_base; > > - memcpy(&pdu->size, ptr, 4); > + pdu->size = le32_to_cpu(*(uint32_t *)ptr); > pdu->id = ptr[4]; > - memcpy(&pdu->tag, ptr + 5, 2); > + pdu->tag = le16_to_cpu(*(uint16_t *)(ptr + 5)); > qemu_co_queue_init(&pdu->complete); > submit_pdu(s, pdu); > } Reviewed-by: Aneesh Kumar K.V -aneesh