From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10242CED24E for ; Tue, 18 Nov 2025 10:32:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLJ0M-0000C4-Fo; Tue, 18 Nov 2025 05:32:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLJ0I-00007o-LK for qemu-devel@nongnu.org; Tue, 18 Nov 2025 05:32:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLJ0D-0003bg-6t for qemu-devel@nongnu.org; Tue, 18 Nov 2025 05:32:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763461917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qpGKVfxpR3uzkZFalIW0XXvc/XZgTdX1WlXEz5efcmk=; b=M1p+/1hubcFs3BqT+2r4fEXQCvJgaFcCI4wcP4FWZkiVzo0yrGAs4Y6BB1SauQhx3SRJJ/ CpcgvRndArRarRntd9O1ry8lq/uL1JTr+/e2MT+UvvSVzN07Mo/cv5P1piPoSYK84SBTy2 kk9DDar44kgC7DJTB5GNFD3OMMlb28Q= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-UYHwd70JO562nr1vLl5HoQ-1; Tue, 18 Nov 2025 05:31:55 -0500 X-MC-Unique: UYHwd70JO562nr1vLl5HoQ-1 X-Mimecast-MFC-AGG-ID: UYHwd70JO562nr1vLl5HoQ_1763461915 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F898195608D; Tue, 18 Nov 2025 10:31:54 +0000 (UTC) Received: from localhost (dhcp-192-224.str.redhat.com [10.33.192.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C6BC11955F1B; Tue, 18 Nov 2025 10:31:53 +0000 (UTC) From: Cornelia Huck To: Peter Maydell Cc: Bernhard Beschow , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini Subject: Re: [PATCH v3 1/2] hw/arm/imx8mp-evk: Add KVM support In-Reply-To: Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Avril Crosse O'Flaherty" References: <20251101120130.236721-1-shentey@gmail.com> <20251101120130.236721-2-shentey@gmail.com> <87v7j8r399.fsf@redhat.com> User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Date: Tue, 18 Nov 2025 11:31:51 +0100 Message-ID: <87seebr5rc.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Nov 17 2025, Peter Maydell wrote: > On Mon, 17 Nov 2025 at 17:13, Cornelia Huck wrote: >> Running current master (resp. with this patch applied), I'm getting make >> check failures on an aarch64 (Mt. Snow) host ("qemu-system-aarch64: >> unknown type 'arm-gicv3'" while using this machine); going back right >> before this patch, everything works fine. Haven't tried to debug this >> yet (maybe I'm the one with the weird config again...) > > Is this a KVM-only config (no TCG) ? Yes, it is. (Forgot about that...) However, I noticed that a build I did after enabling tcg still failed, and only after starting over with a fresh build directory, it worked -- I'm wondering if I managed to trigger an unrelated problem? > > I think this happens because the KConfig now says > + depends on TCG || KVM > > but because the machine by default doesn't use KVM then > trying to run the machine with no extra arguments falls > over if TCG isn't present. > > This thing we put in to handle "creation of the SoC object > via device introspection means it doesn't have an ms->cpu_type > to look at": > > + const char *cpu_type = ms->cpu_type ?: ARM_CPU_TYPE_NAME("cortex-a53"); > > also probably won't do anything useful under a KVM-only config. > > I think the simplest thing here is to put the KConfig back to: > > depends on TCG && AARCH64 > > People building a KVM-only config almost certainly do not > want this machine type and its devices, because the main > reason to build KVM-only is because you're in the > "virtualization use case" and want to not build in a > load of not-security-supported machine types. I think that's a reasonable assumption.