qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Gustavo Romero" <gustavo.romero@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v2] Add -build-info and -build-info-json CLI arguments
Date: Tue, 24 Sep 2024 13:02:26 +0100	[thread overview]
Message-ID: <87setpcl9p.fsf@draig.linaro.org> (raw)
In-Reply-To: <CAAjaMXZ8q0is2-7-kjyBs=YsBc03=0R2XcYiR-fp05=bcerD6Q@mail.gmail.com> (Manos Pitsidianakis's message of "Tue, 24 Sep 2024 12:25:50 +0300")

Manos Pitsidianakis <manos.pitsidianakis@linaro.org> writes:

> Hello Daniel,
>
> On Tue, 24 Sept 2024 at 11:45, Daniel P. Berrangé <berrange@redhat.com> wrote:
>>
>> On Mon, Sep 23, 2024 at 10:09:32PM +0300, Manos Pitsidianakis wrote:
>> > Hello Daniel,
>> >
>> > On Mon, 23 Sep 2024 19:45, "Daniel P. Berrangé" <berrange@redhat.com> wrote:
>> > > On Mon, Sep 23, 2024 at 09:05:24AM +0300, Manos Pitsidianakis wrote:
<snip>
>> > > ie, look a query-audiodevs to discover what audio baxckends are
>> > > built-in, don't look for CONFIG_XXX settings related to audio.
>> > > If there are gaps in information we can query from QMP, we should
>> > > aim to close those gaps.
>> > >
>> > > IOW, I don't think we should expose this build info info in either
>> > > human readable or machine readable format.
>> >
>> > QAPI/QMP is not the perspective of this patch, this is for people who use
>> > custom-built (i.e. not from a distro) binaries and want to be able to
>> > identify how it was built. Launching a binary to query stuff is
>> > unnecessarily complex for this task, and the info is not generally
>> > interesting to the API consumers as you said.
>>
>> Launching QEMU to talk QMP is our defined public API for querying
>> anything about the capabilities of QEMU. We're worked hard to get
>> away from providing ad-hoc ways to query QEMU from the command
>> line and going back to that is not desirable. It may be slightly
>> more complicated, but not by very much.
>
> Again, this is not a "capabilities discovery" API. It lists the
> build-time configuration of the binary. Perhaps we can expose it in a
> different way so that people don't end up confused?

I think the problem is however much we might say it's not a capabilities
discovery API it's very existence encourages users to use it as one.

What about a script:

  qemu-get-build-info </path/to/qemu>

which would launch the binary and query it over QMP? Would that work?

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2024-09-24 12:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23  6:05 [PATCH v2] Add -build-info and -build-info-json CLI arguments Manos Pitsidianakis
2024-09-23 16:45 ` Daniel P. Berrangé
2024-09-23 19:09   ` Manos Pitsidianakis
2024-09-24  8:45     ` Daniel P. Berrangé
2024-09-24  9:25       ` Manos Pitsidianakis
2024-09-24 12:02         ` Alex Bennée [this message]
2024-09-24 12:08           ` Daniel P. Berrangé
2024-09-24 12:32             ` Manos Pitsidianakis
2024-09-25 17:28             ` Pierrick Bouvier
2024-09-23 16:56 ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87setpcl9p.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=gustavo.romero@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).