qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	qemu-block@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Lukas Straub" <lukasstraub2@web.de>,
	"Ani Sinha" <anisinha@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Hanna Reitz" <hreitz@redhat.com>, "Mads Ynddal" <mads@ynddal.dk>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Jiri Pirko" <jiri@resnulli.us>
Subject: Re: [PATCH 5/8] qapi: convert "Example" sections without titles
Date: Sat, 06 Jul 2024 16:42:28 +0200	[thread overview]
Message-ID: <87sewmtwdn.fsf@pond.sub.org> (raw)
In-Reply-To: <20240703210144.339530-6-jsnow@redhat.com> (John Snow's message of "Wed, 3 Jul 2024 17:01:40 -0400")

John Snow <jsnow@redhat.com> writes:

> Use the no-option form of ".. qmp-example::" to convert any Examples
> that do not have any form of caption or explanation whatsoever. Note
> that in a few cases, example sections are split into two or more
> separate example blocks. This is only done stylistically to create a
> delineation between two or more logically independent examples.
>
> See commit-3: "docs/qapidoc: create qmp-example directive", for a
>               detailed explanation of this custom directive syntax.
>
> See commit+3: "qapi: remove "Example" doc section" for a detailed
>               explanation of why.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

[...]

> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 252d7d6afa7..718a3c958e9 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json

[...]

> @@ -453,7 +453,7 @@
>  #
>  # Since: 5.0
>  #
> -# Example:
> +# .. qmp-example::
>  #
>  #     <- { "event": "GUEST_CRASHLOADED",
>  #          "data": { "action": "run" },

Trivial semantic conflict, we need

  @@ -469,7 +469,7 @@
   #
   # Since: 9.1
   #
  -# Example:
  +# .. qmp-example::
   #
   #     <- { "event": "GUEST_PVSHUTDOWN",
   #          "timestamp": { "seconds": 1648245259, "microseconds": 893771 } }


> @@ -597,7 +597,7 @@
>  #
>  # Since: 5.2
>  #
> -# Example:
> +# .. qmp-example::
>  #
>  #     <- { "event": "MEMORY_FAILURE",
>  #          "data": { "recipient": "hypervisor",

[...]



  reply	other threads:[~2024-07-06 14:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 21:01 [PATCH 0/8] qapi: convert example sections to qmp-example rST directives John Snow
2024-07-03 21:01 ` [PATCH 1/8] docs/qapidoc: factor out do_parse() John Snow
2024-07-06 14:47   ` Markus Armbruster
2024-07-06 19:57     ` John Snow
2024-07-09 10:28       ` Markus Armbruster
2024-07-03 21:01 ` [PATCH 2/8] docs/qapidoc: create qmp-example directive John Snow
2024-07-09 10:29   ` Markus Armbruster
2024-07-03 21:01 ` [PATCH 3/8] docs/qapidoc: add QMP highlighting to annotated qmp-example blocks John Snow
2024-07-09 10:33   ` Markus Armbruster
2024-07-09 22:47     ` John Snow
2024-07-03 21:01 ` [PATCH 4/8] docs/sphinx: add CSS styling for qmp-example directive John Snow
2024-07-09 10:33   ` Markus Armbruster
2024-07-09 22:55     ` John Snow
2024-07-10  4:37       ` Markus Armbruster
2024-07-03 21:01 ` [PATCH 5/8] qapi: convert "Example" sections without titles John Snow
2024-07-06 14:42   ` Markus Armbruster [this message]
2024-07-06 19:56     ` John Snow
2024-07-09 11:16       ` Markus Armbruster
2024-07-03 21:01 ` [PATCH 6/8] qapi: convert "Example" sections with titles John Snow
2024-07-09 11:30   ` Markus Armbruster
2024-07-03 21:01 ` [PATCH 7/8] qapi: convert "Example" sections with longer prose John Snow
2024-07-09 11:35   ` Markus Armbruster
2024-07-09 22:57     ` John Snow
2024-07-03 21:01 ` [PATCH 8/8] qapi: remove "Example" doc section John Snow
2024-07-09 10:52   ` Markus Armbruster
2024-07-09 23:12     ` John Snow
2024-07-10  5:44       ` Markus Armbruster
2024-07-10 14:46         ` John Snow
2024-07-09 16:55 ` [PATCH 0/8] qapi: convert example sections to qmp-example rST directives Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sewmtwdn.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=farosas@suse.de \
    --cc=hreitz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=mads@ynddal.dk \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).