From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2614ACE7B19 for ; Thu, 28 Sep 2023 10:53:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlodr-0005dI-QU; Thu, 28 Sep 2023 06:53:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlodq-0005d2-9a for qemu-devel@nongnu.org; Thu, 28 Sep 2023 06:53:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlodo-0006Ek-TG for qemu-devel@nongnu.org; Thu, 28 Sep 2023 06:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695898387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=izLxSQpu7KfcG0NyLvkv3YSkaP19cf0+PvEzPzTQRfE=; b=ObjyivYy+iwx1em9nHxAxQkgHeH4JQzdA4ZEUIv0u3b3ReQG36qItiMUBoOS8h8T4pDLLx i8FNwYmgMH3pVXyzTDMnvLNPYnlTk+s8b1lOF/3LzjVrgcNHOSXYrloIg5mj/qHIZNnTcp Uyi93KES92Znoh2IJ9iKwElIE14yz3E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-118-DPcwg2OXO1mcS1u3EaSfrg-1; Thu, 28 Sep 2023 06:53:03 -0400 X-MC-Unique: DPcwg2OXO1mcS1u3EaSfrg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61511803533; Thu, 28 Sep 2023 10:53:03 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BDFEC15BB8; Thu, 28 Sep 2023 10:53:03 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1273B21E6900; Thu, 28 Sep 2023 12:53:02 +0200 (CEST) From: Markus Armbruster To: "Zhijian Li (Fujitsu)" Cc: Markus Armbruster , "qemu-devel@nongnu.org" , "quintela@redhat.com" , "peterx@redhat.com" , "leobras@redhat.com" Subject: Re: [PATCH 08/52] migration/rdma: Fix qemu_rdma_accept() to return failure on errors References: <20230918144206.560120-1-armbru@redhat.com> <20230918144206.560120-9-armbru@redhat.com> <3ff28a57-4aa7-2541-23ca-28d2acb36cc4@fujitsu.com> Date: Thu, 28 Sep 2023 12:53:02 +0200 In-Reply-To: <3ff28a57-4aa7-2541-23ca-28d2acb36cc4@fujitsu.com> (Zhijian Li's message of "Thu, 21 Sep 2023 09:07:50 +0000") Message-ID: <87sf6yfu29.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org "Zhijian Li (Fujitsu)" writes: > On 18/09/2023 22:41, Markus Armbruster wrote: >> qemu_rdma_accept() returns 0 in some cases even when it didn't >> complete its job due to errors. Impact is not obvious. I figure the >> caller will soon fail again with a misleading error message. >> >> Fix it to return -1 on any failure. >> >> Signed-off-by: Markus Armbruster > > I noticed that ret initialization is also meaningless in qemu_rdma_accept() > > 3354 static int qemu_rdma_accept(RDMAContext *rdma) > 3355 { > 3356 RDMACapabilities cap; > 3357 struct rdma_conn_param conn_param = { > 3358 .responder_resources = 2, > 3359 .private_data = &cap, > 3360 .private_data_len = sizeof(cap), > 3361 }; > 3362 RDMAContext *rdma_return_path = NULL; > 3363 struct rdma_cm_event *cm_event; > 3364 struct ibv_context *verbs; > 3365 int ret = -EINVAL; <<<<< drop it ? > 3366 int idx; PATCH 27 will drop it. > Reviewed-by: Li Zhijian Thanks!