qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Matt Borgerson" <contact@mborgerson.com>,
	qemu-devel@nongnu.org,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end
Date: Mon, 17 Jul 2023 16:34:02 +0100	[thread overview]
Message-ID: <87sf9mwnzo.fsf@linaro.org> (raw)
In-Reply-To: <874jm2ya3g.fsf@linaro.org>


Alex Bennée <alex.bennee@linaro.org> writes:

> Matt Borgerson <contact@mborgerson.com> writes:
>
>> Translation logic may partially decode an instruction, then abort and
>> remove the instruction from the TB. This can happen for example when an
>> instruction spans two pages. In this case, plugins may get an incorrect
>> result when calling qemu_plugin_tb_n_insns to query for the number of
>> instructions in the TB. This patch updates plugin_gen_tb_end to set the
>> final instruction count.
>
> For some reason this fails to apply cleanly:
>
>   git am ./v2_20230714_contact_plugins_set_final_instruction_count_in_plugin_gen_tb_end.mbx
>   Applying: plugins: Set final instruction count in plugin_gen_tb_end
>   error: corrupt patch at line 31           
>   Patch failed at 0001 plugins: Set final instruction count in
>   plugin_gen_tb_end

I think some newlines crept in, I was able to fix. Queued to
for-8.1/misc-fixes with the assert added.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2023-07-17 15:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 18:32 [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end Matt Borgerson
2023-07-17 12:49 ` Alex Bennée
2023-07-17 15:34   ` Alex Bennée [this message]
2023-07-17 19:21     ` Matt Borgerson
2023-07-18 22:05       ` Alex Bennée
2023-08-24 15:59         ` Philippe Mathieu-Daudé
2023-08-30 18:47 ` Alex Bennée
2023-08-30 19:12   ` Matt Borgerson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf9mwnzo.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=contact@mborgerson.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).