From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0010EEB64DC for ; Mon, 3 Jul 2023 08:47:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGFDa-0004BM-Hy; Mon, 03 Jul 2023 04:47:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGFDU-00049F-CQ for qemu-devel@nongnu.org; Mon, 03 Jul 2023 04:47:28 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGFDQ-0003JE-FD for qemu-devel@nongnu.org; Mon, 03 Jul 2023 04:47:27 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b6a084a34cso60924041fa.1 for ; Mon, 03 Jul 2023 01:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688374040; x=1690966040; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=7aKOS5oNxly952rEbKKoK5WrKou4NEB8671919LU0Pw=; b=W4ZfsqueXdEGlhl5lr9PPgTB753ZYZmgshoe3Cy2wbmi4eC+JphOlMgRRZMDgvn+Zt xXVACIMRToAChCt29XeRrJ7gxhoQU65RYtA3YWnoEsPCsuNK8RczKuTsNK3uSQmDbTi3 wucmTxI5IKTVvwnAIaGScbvjuv/e8rfvIQm4oKXelldLh/RzlH3Ykb2CObbw+yZIFXB0 4eRd+syq2fHtmYHdwWelxMtF6ffmIcYlQZ1XwrEJSHzpzXh4mbYOAqS+e65aMMkWfoyd RHUwYTjh/93JyzmUjB+eWmYrbX1ADvvXXFat0N33r7zysJSPfui4tIVbFqBHA44/QTex TFUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688374040; x=1690966040; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7aKOS5oNxly952rEbKKoK5WrKou4NEB8671919LU0Pw=; b=ZR7LpuKdkXV25GO3o1GI/YchQ+3vXfXo54MEm+oAasiSFmCTgB/GHGPPa606iMtqxm uUt/ldcvYC+7WuB50UgA6HS9ycZ8gnhzhdBnGzNDQqutzUqQtUsCVp+bWUpOo020QdHu VyTIQUD3xzjpixy9sPm6Lt2YKzvrXNOOoJyUgoYFF8pl/cEdJsfl+bNi+4QP+q77iWgq 5D7z5pPhjMQtGBZfsAKt2feDeGy4x7oxll9kj+Rxh/m09Da+aDSP1j+xhmOO9cxwDT5x +Zu9uuRmsap+EHdvDamfkUkpJ3AnigOcdzkbfUh+MTWHo75f9zs6AOj3pBxV7COIPrfQ bH6w== X-Gm-Message-State: ABy/qLaz7arhsiR1ZWkNn/fY55e3N8iggrPbP3K8rie3Y2Eqk8epWsOi Hg/4DOKsD58TLScvKuFbrSSQNJbsgt37GTvI4zc= X-Google-Smtp-Source: APBJJlFT1jZEIqtAZBkx24nQYZfi6si81wp0zrKzNgKWU3o6BDA2cJ5sRbFUBVelLHZxI5dZbmMSEQ== X-Received: by 2002:a2e:7c0f:0:b0:2b6:d7a0:c27d with SMTP id x15-20020a2e7c0f000000b002b6d7a0c27dmr4087835ljc.37.1688374040552; Mon, 03 Jul 2023 01:47:20 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id o16-20020a1c7510000000b003f9b155b148sm29287660wmc.34.2023.07.03.01.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 01:47:20 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id BC8211FFBB; Mon, 3 Jul 2023 09:47:19 +0100 (BST) References: <20230630132159.376995-1-richard.henderson@linaro.org> <20230630132159.376995-2-richard.henderson@linaro.org> User-agent: mu4e 1.11.8; emacs 29.0.92 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Cc: mjt@tls.msk.ru, laurent@vivier.eu, qemu-devel@nongnu.org Subject: Re: [PATCH 01/24] linux-user: Use assert in mmap_fork_start Date: Mon, 03 Jul 2023 09:47:15 +0100 In-reply-to: <20230630132159.376995-2-richard.henderson@linaro.org> Message-ID: <87sfa5jsa0.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Richard Henderson writes: > Assert is preferred over if+abort for the error message. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro