From: "Alex Bennée" <alex.bennee@linaro.org>
To: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Cc: qemu-devel@nongnu.org, bcain@quicinc.com, f4bug@amsat.org,
peter.maydell@linaro.org, tsimpson@quicinc.com
Subject: Re: [PATCH v2 RESEND 2/7] gdbstub: add test for untimely stop-reply packets
Date: Thu, 20 Apr 2023 14:44:11 +0100 [thread overview]
Message-ID: <87sfcud5x9.fsf@linaro.org> (raw)
In-Reply-To: <135d716c2f1cdc125a3d44f5f6a0e67da13de744.1681993775.git.quic_mathbern@quicinc.com>
Matheus Tavares Bernardino <quic_mathbern@quicinc.com> writes:
> In the previous commit, we modified gdbstub.c to only send stop-reply
> packets as a response to GDB commands that accept it. Now, let's add a
> test for this intended behavior. Running this test before the fix from
> the previous commit fails as QEMU sends a stop-reply packet
> asynchronously, when GDB was in fact waiting an ACK.
>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Excellent work adding some more gdb testing ;-)
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-04-20 13:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:31 [PATCH v2 RESEND 0/7] Hexagon: add lldb support Matheus Tavares Bernardino
2023-04-20 12:31 ` [PATCH v2 RESEND 1/7] gdbstub: only send stop-reply packets when allowed to Matheus Tavares Bernardino
2023-04-20 13:41 ` Alex Bennée
2023-04-21 11:31 ` Matheus Tavares Bernardino
2023-04-20 12:31 ` [PATCH v2 RESEND 2/7] gdbstub: add test for untimely stop-reply packets Matheus Tavares Bernardino
2023-04-20 13:44 ` Alex Bennée [this message]
2023-04-20 12:31 ` [PATCH v2 RESEND 3/7] gdbstub: add support for the qRegisterInfo query Matheus Tavares Bernardino
2023-04-20 13:49 ` Alex Bennée
2023-04-21 11:34 ` Matheus Tavares Bernardino
2023-04-21 13:17 ` Alex Bennée
2023-04-20 14:04 ` Philippe Mathieu-Daudé
2023-04-20 14:05 ` Philippe Mathieu-Daudé
2023-04-20 12:31 ` [PATCH v2 RESEND 4/7] Hexagon: support qRegisterInfo at gdbstub Matheus Tavares Bernardino
2023-04-20 14:06 ` Philippe Mathieu-Daudé
2023-04-21 11:40 ` Matheus Tavares Bernardino
2023-04-20 12:31 ` [PATCH v2 RESEND 5/7] Hexagon (gdbstub): fix p3:0 read and write via stub Matheus Tavares Bernardino
2023-04-20 12:31 ` [PATCH v2 RESEND 6/7] Hexagon (gdbstub): add HVX support Matheus Tavares Bernardino
2023-04-20 12:31 ` [PATCH v2 RESEND 7/7] Hexagon (linux-user/hexagon): handle breakpoints Matheus Tavares Bernardino
2023-04-27 13:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfcud5x9.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).