From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0BD8C77B6E for ; Fri, 14 Apr 2023 11:55:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnI1h-0003Ux-Jk; Fri, 14 Apr 2023 07:55:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnI1f-0003Lk-Vk; Fri, 14 Apr 2023 07:55:36 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnI1d-0005Xj-JW; Fri, 14 Apr 2023 07:55:35 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C5501FD95; Fri, 14 Apr 2023 11:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681473332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wAxPjo36kgElJoSLWatd8hUO1KUWUTk8URgrLyNVeBQ=; b=tgkXRvCdkg6o1QPjxeoHDWJLlHM+afdtSu9Ma28NayTw314xxDI6ha2ME39OJ6r3uDkyKC be9VeyJaqC3DnbxsuwRWe9ZzB8tw9TV3tAiCFTAUFqEjxOwsDS4L42ORUISwPQXrAfYp60 9iL8ab2HLGI1zb+lr9Z4+JYUv4GVhSA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681473332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wAxPjo36kgElJoSLWatd8hUO1KUWUTk8URgrLyNVeBQ=; b=9dXD+WCBgctWQmlbPaNIyfpHLxhqGw8M3o01bPeCgw3wZhy/ZUwoNEqocKKfhlPpYJiebg 392wAN5AG0rZopCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9BB6313498; Fri, 14 Apr 2023 11:55:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VBKRGDM/OWQBVgAAMHmgww (envelope-from ); Fri, 14 Apr 2023 11:55:31 +0000 From: Fabiano Rosas To: Harsh Prateek Bora , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, danielhb413@gmail.com Subject: Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested() In-Reply-To: <20230331065344.112341-4-harshpb@linux.ibm.com> References: <20230331065344.112341-1-harshpb@linux.ibm.com> <20230331065344.112341-4-harshpb@linux.ibm.com> Date: Fri, 14 Apr 2023 08:55:29 -0300 Message-ID: <87sfd2ispa.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Harsh Prateek Bora writes: > Currently, it asserts very late in the code flow if lpid is already initialized. That's not about initializing. It is about making sure the LPIDR is 0. Which has a specific meaning according to the ISA. > Ideally, it should assert in the beginning if that is the case. This patch > brings assert check in the beginning alongwith the related initialization. > Maybe just leave it where it is. There's not much to gain from moving this.