Re: [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message

[Juan Quintela <quintela@redhat.com>]

Markus Armbruster <armbru@redhat.com> wrote:
> The script drops #include "qemu/osdep.h" from headers.  Mention it in
> the commit message it uses for --git.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  scripts/clean-includes | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/clean-includes b/scripts/clean-includes
> index f0466a6262..f9722c3aec 100755
> --- a/scripts/clean-includes
> +++ b/scripts/clean-includes
> @@ -193,8 +193,8 @@ if [ "$GIT" = "yes" ]; then
>      git commit --signoff -F - <<EOF
>  $GITSUBJ: Clean up includes
>  
> -Clean up includes so that osdep.h is included first and headers
> -which it implies are not included manually.
> +Clean up includes so that qemu/osdep.h is included first in .c, and
> +not in .h, and headers which it implies are not included manually.

I give a tree.

Clean up includes so qemu/osdep.h is never used in .h files.  It makes
sure that qemu/osdep.h is only used in .c files.  Once there, it assures
that .h files already included in qemu/osdep.h are not included a second
time on the .c file.

What do you think?
And yes, not using "include" the "include files" is .... interesting/confusing/....


Anyways, if you preffer old text or net one.

Reviewed-by: Juan Quintela <quintela@redhat.com>