From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Huacai Chen <chenhuacai@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
BALATON Zoltan via <qemu-devel@nongnu.org>
Subject: Re: [RFC PATCH 2/2] tests/tcg/mips64el: Run float tests
Date: Tue, 04 Jan 2022 10:59:41 +0000 [thread overview]
Message-ID: <87sfu3lq97.fsf@linaro.org> (raw)
In-Reply-To: <ada264bd-6277-0c44-b010-cbbe93e98a8e@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> On 12/26/21 03:25, Jiaxun Yang wrote:
>> 在2021年12月26日十二月 上午12:19，Philippe Mathieu-Daudé写道：
>>> Unfortunately this fails:
>>>
>>> $ make run-tcg-tests-mips64el-linux-user
>>> ...
>>> Files float_convs.out and tests/tcg/mips64el/float_convs.ref differ
>>> --- float_convs.out 2021-12-26 01:03:48.585973637 +0100
>>> +++ tests/tcg/mips64el/float_convs.ref 2021-12-26 00:29:35.804465340 +0100
>>> @@ -1,40 +1,40 @@
>>> ### Rounding to nearest
>>> -from single: f32(nan:0xffffffff)
>>> - to double: f64(nan:0x007ff7ffffffffffff) (INVALID)
>>> - to int32: 2147483647 (INVALID)
>>> - to int64: 9223372036854775807 (INVALID)
>>> - to uint32: 2147483647 (INVALID)
>>> - to uint64: 9223372036854775807 (INVALID)
>>> make[2]: *** [tests/tcg/multiarch/Makefile.target:32: run-float_convs] Error 1
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> tests/tcg/mips64el/Makefile.target | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> create mode 100644 tests/tcg/mips64el/Makefile.target
>>>
>>> diff --git a/tests/tcg/mips64el/Makefile.target
>>> b/tests/tcg/mips64el/Makefile.target
>>> new file mode 100644
>>> index 00000000000..dcb1e9d72ac
>>> --- /dev/null
>>> +++ b/tests/tcg/mips64el/Makefile.target
>>> @@ -0,0 +1,2 @@
>>> +float_%: CFLAGS+=-march=loongson3a
>>> +float_%: QEMU_OPTS+=-cpu Loongson-3A4000
>>
>> Hmm, -march=loongson3a assumed legacy NaN while our -cpu Loongson-3A4000 assumed IEEE 754-2008 style NaN.
>>
>> I guess switch to Loongson-3A1000 can help?
>
> Nop, exactly the same error.
>
> Also, float_madds fails as:
>
> Files float_madds.out and tests/tcg/mips64el/float_madds.ref differ
> --- float_madds.out 2021-12-26 11:49:06.018532269 +0100
> +++ tests/tcg/mips64el/float_madds.ref 2021-12-26 01:16:02.269497182 +0100
> @@ -1,16 +1,16 @@
> ### Rounding to nearest
> -op : f32(nan:0xffffffff) * f32(nan:0xffbfffff) + f32(-inf:0xff800000)
> -res: f32(nan:0x7fbfffff) flags=INVALID (0/0)
> -op : f32(nan:0xffbfffff) * f32(-inf:0xff800000) + f32(nan:0xffffffff)
> -res: f32(nan:0x7fbfffff) flags=INVALID (0/1)
> -op : f32(-inf:0xff800000) * f32(nan:0xffffffff) + f32(nan:0xffbfffff)
> -res: f32(nan:0x7fbfffff) flags=INVALID (0/2)
> make[2]: *** [tests/tcg/multiarch/Makefile.target:30: run-float_madds]
> Error 1
That looks like the test just stops (rather than differs slightly) -
which is weird because I would expect that to fail before attempting to
compare to the reference.
--
Alex Bennée
prev parent reply other threads:[~2022-01-04 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 0:19 [PATCH 0/2] tests/tcg/mips64el: Run float tests Philippe Mathieu-Daudé
2021-12-26 0:19 ` [PATCH 1/2] tests/tcg/mips64el: Add float reference files Philippe Mathieu-Daudé
2021-12-26 0:19 ` [RFC PATCH 2/2] tests/tcg/mips64el: Run float tests Philippe Mathieu-Daudé
2021-12-26 2:25 ` Jiaxun Yang
2021-12-26 10:50 ` Philippe Mathieu-Daudé
2022-01-04 10:59 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfu3lq97.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).