From: "Alex Bennée" <alex.bennee@linaro.org>
To: Christophe de Dinechin <dinechin@redhat.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs
Date: Mon, 29 Jun 2020 11:08:43 +0100 [thread overview]
Message-ID: <87sgeerxp0.fsf@linaro.org> (raw)
In-Reply-To: <20200629094934.2081180-1-dinechin@redhat.com>
Christophe de Dinechin <dinechin@redhat.com> writes:
> The vmgenid.o is the only file that is not in alphabetical order.
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> stubs/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index f32b9e47a3..1df8bb3814 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -19,10 +19,10 @@ stub-obj-y += replay.o
> stub-obj-y += runstate-check.o
> stub-obj-$(CONFIG_SOFTMMU) += semihost.o
> stub-obj-y += set-fd-handler.o
> -stub-obj-y += vmgenid.o
> stub-obj-y += sysbus.o
> stub-obj-y += tpm.o
> stub-obj-y += trace-control.o
> +stub-obj-y += vmgenid.o
> stub-obj-y += vmstate.o
> stub-obj-$(CONFIG_SOFTMMU) += win32-kbd-hook.o
--
Alex Bennée
next prev parent reply other threads:[~2020-06-29 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 9:49 [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs Christophe de Dinechin
2020-06-29 10:08 ` Alex Bennée [this message]
2020-06-29 10:19 ` Philippe Mathieu-Daudé
2020-07-06 16:31 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgeerxp0.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=dinechin@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).