* [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs
@ 2020-06-29 9:49 Christophe de Dinechin
2020-06-29 10:08 ` Alex Bennée
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christophe de Dinechin @ 2020-06-29 9:49 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, Laurent Vivier
The vmgenid.o is the only file that is not in alphabetical order.
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
---
stubs/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index f32b9e47a3..1df8bb3814 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -19,10 +19,10 @@ stub-obj-y += replay.o
stub-obj-y += runstate-check.o
stub-obj-$(CONFIG_SOFTMMU) += semihost.o
stub-obj-y += set-fd-handler.o
-stub-obj-y += vmgenid.o
stub-obj-y += sysbus.o
stub-obj-y += tpm.o
stub-obj-y += trace-control.o
+stub-obj-y += vmgenid.o
stub-obj-y += vmstate.o
stub-obj-$(CONFIG_SOFTMMU) += win32-kbd-hook.o
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs
2020-06-29 9:49 [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs Christophe de Dinechin
@ 2020-06-29 10:08 ` Alex Bennée
2020-06-29 10:19 ` Philippe Mathieu-Daudé
2020-07-06 16:31 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-06-29 10:08 UTC (permalink / raw)
To: Christophe de Dinechin
Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, Laurent Vivier,
qemu-devel
Christophe de Dinechin <dinechin@redhat.com> writes:
> The vmgenid.o is the only file that is not in alphabetical order.
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> stubs/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index f32b9e47a3..1df8bb3814 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -19,10 +19,10 @@ stub-obj-y += replay.o
> stub-obj-y += runstate-check.o
> stub-obj-$(CONFIG_SOFTMMU) += semihost.o
> stub-obj-y += set-fd-handler.o
> -stub-obj-y += vmgenid.o
> stub-obj-y += sysbus.o
> stub-obj-y += tpm.o
> stub-obj-y += trace-control.o
> +stub-obj-y += vmgenid.o
> stub-obj-y += vmstate.o
> stub-obj-$(CONFIG_SOFTMMU) += win32-kbd-hook.o
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs
2020-06-29 9:49 [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs Christophe de Dinechin
2020-06-29 10:08 ` Alex Bennée
@ 2020-06-29 10:19 ` Philippe Mathieu-Daudé
2020-07-06 16:31 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-29 10:19 UTC (permalink / raw)
To: Christophe de Dinechin, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, Laurent Vivier
On 6/29/20 11:49 AM, Christophe de Dinechin wrote:
> The vmgenid.o is the only file that is not in alphabetical order.
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> stubs/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index f32b9e47a3..1df8bb3814 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -19,10 +19,10 @@ stub-obj-y += replay.o
> stub-obj-y += runstate-check.o
> stub-obj-$(CONFIG_SOFTMMU) += semihost.o
> stub-obj-y += set-fd-handler.o
> -stub-obj-y += vmgenid.o
> stub-obj-y += sysbus.o
> stub-obj-y += tpm.o
> stub-obj-y += trace-control.o
> +stub-obj-y += vmgenid.o
> stub-obj-y += vmstate.o
> stub-obj-$(CONFIG_SOFTMMU) += win32-kbd-hook.o
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs
2020-06-29 9:49 [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs Christophe de Dinechin
2020-06-29 10:08 ` Alex Bennée
2020-06-29 10:19 ` Philippe Mathieu-Daudé
@ 2020-07-06 16:31 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-07-06 16:31 UTC (permalink / raw)
To: Christophe de Dinechin, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev
Le 29/06/2020 à 11:49, Christophe de Dinechin a écrit :
> The vmgenid.o is the only file that is not in alphabetical order.
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> stubs/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index f32b9e47a3..1df8bb3814 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -19,10 +19,10 @@ stub-obj-y += replay.o
> stub-obj-y += runstate-check.o
> stub-obj-$(CONFIG_SOFTMMU) += semihost.o
> stub-obj-y += set-fd-handler.o
> -stub-obj-y += vmgenid.o
> stub-obj-y += sysbus.o
> stub-obj-y += tpm.o
> stub-obj-y += trace-control.o
> +stub-obj-y += vmgenid.o
> stub-obj-y += vmstate.o
> stub-obj-$(CONFIG_SOFTMMU) += win32-kbd-hook.o
>
>
Applied to my trivial-patches-for-5.1 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-06 16:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-29 9:49 [PATCH] trivial: Respect alphabetical order of .o files in Makefile.objs Christophe de Dinechin
2020-06-29 10:08 ` Alex Bennée
2020-06-29 10:19 ` Philippe Mathieu-Daudé
2020-07-06 16:31 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).