From: "Alex Bennée" <alex.bennee@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com,
rth@twiddle.net
Subject: Re: [PATCH 1/5] target/i386: implement special cases for fxtract
Date: Fri, 15 May 2020 09:59:09 +0100 [thread overview]
Message-ID: <87sgg1d15u.fsf@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2005070042360.18350@digraph.polyomino.org.uk>
Joseph Myers <joseph@codesourcery.com> writes:
> The implementation of the fxtract instruction treats all nonzero
> operands as normal numbers, so yielding incorrect results for invalid
> formats, infinities, NaNs and subnormal and pseudo-denormal operands.
> Implement appropriate handling of all those cases.
>
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> ---
> target/i386/fpu_helper.c | 25 +++++-
> tests/tcg/i386/test-i386-fxtract.c | 120 +++++++++++++++++++++++++++++
> 2 files changed, 144 insertions(+), 1 deletion(-)
> create mode 100644 tests/tcg/i386/test-i386-fxtract.c
>
For test tests:
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2020-05-15 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 0:42 [PATCH 0/5] target/i386: fxtract, fscale fixes Joseph Myers
2020-05-07 0:43 ` [PATCH 1/5] target/i386: implement special cases for fxtract Joseph Myers
2020-05-15 8:59 ` Alex Bennée [this message]
2020-06-23 21:42 ` Eduardo Habkost
2020-06-23 22:00 ` Joseph Myers
2020-06-25 9:43 ` Peter Maydell
2020-05-07 0:44 ` [PATCH 2/5] target/i386: fix fscale handling of signaling NaN Joseph Myers
2020-05-07 0:44 ` [PATCH 3/5] target/i386: fix fscale handling of invalid exponent encodings Joseph Myers
2020-05-07 0:45 ` [PATCH 4/5] target/i386: fix fscale handling of infinite exponents Joseph Myers
2020-05-07 0:46 ` [PATCH 5/5] target/i386: fix fscale handling of rounding precision Joseph Myers
2020-05-07 2:13 ` [PATCH 0/5] target/i386: fxtract, fscale fixes no-reply
2020-05-07 14:57 ` Joseph Myers
2020-05-08 3:42 ` Richard Henderson
2020-05-14 18:25 ` Ping " Joseph Myers
2020-05-14 23:02 ` Paolo Bonzini
2020-05-15 7:03 ` Philippe Mathieu-Daudé
2020-05-21 15:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgg1d15u.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=joseph@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).