From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C10C43603 for ; Thu, 19 Dec 2019 06:54:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AC30222C2 for ; Thu, 19 Dec 2019 06:54:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dSI1MOjF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AC30222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihphD-0004dd-EH for qemu-devel@archiver.kernel.org; Thu, 19 Dec 2019 01:54:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38773) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihpgO-00048o-Uy for qemu-devel@nongnu.org; Thu, 19 Dec 2019 01:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihpgM-0003pl-HH for qemu-devel@nongnu.org; Thu, 19 Dec 2019 01:53:11 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:58391 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihpgM-0003l6-4o for qemu-devel@nongnu.org; Thu, 19 Dec 2019 01:53:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576738386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qxzXx+71n4empVY6KRCherhudWNv9rkASvNeiT9MKds=; b=dSI1MOjF55gFam0bbfeMLgwirRPnoWajuDH/PSrr88lyBxiXZdbM1uMujp72poYq09dltb tmFwIZgAxf/jkIKmT9GZCDaYH2Q36w+hlVRudUKucZ9+7rKFEfqnNQkNV1pTqxruPoARaj lIEVBim33SPJfk2Vl+S8Ta2Tqzg+bLg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-M1OOxZS7ODWAYahXKaS8VA-1; Thu, 19 Dec 2019 01:53:04 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6EFE7184BEC0; Thu, 19 Dec 2019 06:52:59 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-42.ams2.redhat.com [10.36.116.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1788D10013A1; Thu, 19 Dec 2019 06:52:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9EAB111386A7; Thu, 19 Dec 2019 07:52:46 +0100 (CET) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler References: <20191217163808.20068-1-philmd@redhat.com> <20191217163808.20068-14-philmd@redhat.com> Date: Thu, 19 Dec 2019 07:52:46 +0100 In-Reply-To: <20191217163808.20068-14-philmd@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Tue, 17 Dec 2019 17:38:07 +0100") Message-ID: <87sglgx0w1.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: M1OOxZS7ODWAYahXKaS8VA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , Paul Burton , Jason Wang , qemu-devel@nongnu.org, KONRAD Frederic , Gerd Hoffmann , "Edgar E. Iglesias" , Alberto Garcia , Li Zhijian , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Halil Pasic , Christian Borntraeger , "Gonglei \(Arei\)" , Antony Pavlov , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Aleksandar Rikalo , Joel Stanley , Laurent Vivier , Corey Minyard , Amit Shah , Alistair Francis , "Dr. David Alan Gilbert" , Fabien Chouteau , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Peter Chubb , Samuel Thibault , Alex =?utf-8?Q?Benn=C3=A9e?= , Kevin Wolf , qemu-riscv@nongnu.org, Igor Mitsyanko , Bastian Koppelmann , Cornelia Huck , Max Reitz , Zhang Chen , Michael Walle , Palmer Dabbelt , Thomas Huth , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > The Chardev events are listed in the QEMUChrEvent enum. To be > able to use this enum in the IOEventHandler typedef, we need to > explicit when frontends ignore some events, to silent GCC the > following warnings: > > CC s390x-softmmu/hw/char/terminal3270.o > hw/char/terminal3270.c: In function =E2=80=98chr_event=E2=80=99: > hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVE= NT_BREAK=E2=80=99 not handled in switch [-Werror=3Dswitch] > 156 | switch (event) { > | ^~~~~~ > hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVE= NT_MUX_IN=E2=80=99 not handled in switch [-Werror=3Dswitch] > hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVE= NT_MUX_OUT=E2=80=99 not handled in switch [-Werror=3Dswitch] > cc1: all warnings being treated as errors > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: qemu-s390x@nongnu.org > --- > hw/char/terminal3270.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/char/terminal3270.c b/hw/char/terminal3270.c > index 6859c1bcb2..9e59a2d92b 100644 > --- a/hw/char/terminal3270.c > +++ b/hw/char/terminal3270.c > @@ -166,6 +166,9 @@ static void chr_event(void *opaque, int event) > sch->curr_status.scsw.dstat =3D SCSW_DSTAT_DEVICE_END; > css_conditional_io_interrupt(sch); > break; > + default: > + /* Ignore */ > + break; > } > } I doubt the /* Ignore */ comment is worth its keep. Splitting PATCH 02-13 feels excessive to me.