From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffTRD-0002XU-Hw for qemu-devel@nongnu.org; Tue, 17 Jul 2018 13:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffTR8-0000M1-Kr for qemu-devel@nongnu.org; Tue, 17 Jul 2018 13:06:59 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49110 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ffTR8-0000La-FJ for qemu-devel@nongnu.org; Tue, 17 Jul 2018 13:06:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1495B401EF05 for ; Tue, 17 Jul 2018 17:06:54 +0000 (UTC) From: Juan Quintela In-Reply-To: <13a77722-0a4e-ede7-60e9-749278c39d3a@redhat.com> (Thomas Huth's message of "Tue, 17 Jul 2018 16:06:59 +0200") References: <20180717113402.5510-1-quintela@redhat.com> <20180717113402.5510-21-quintela@redhat.com> <13a77722-0a4e-ede7-60e9-749278c39d3a@redhat.com> Reply-To: quintela@redhat.com Date: Tue, 17 Jul 2018 19:06:51 +0200 Message-ID: <87sh4hyeok.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com, Gerd Hoffmann Thomas Huth wrote: > On 17.07.2018 13:33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index b3e707e8c3..ccf71bddcc 100644 >> --- a/tests/Makefile.include >> +++ b/tests/Makefile.include >> @@ -288,8 +288,8 @@ check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF) >> gcov-files-i386-y += hw/usb/hcd-ehci.c >> gcov-files-i386-y += hw/usb/dev-hid.c >> gcov-files-i386-y += hw/usb/dev-storage.c >> -check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF) >> -gcov-files-i386-y += hw/usb/hcd-xhci.c >> +check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF) >> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c >> check-qtest-i386-y += tests/cpu-plug-test$(EXESUF) >> check-qtest-i386-y += tests/q35-test$(EXESUF) >> check-qtest-i386-y += tests/vmgenid-test$(EXESUF) >> @@ -347,8 +347,8 @@ check-qtest-ppc64-y += tests/usb-hcd-ohci-test$(EXESUF) >> gcov-files-ppc64-y += hw/usb/hcd-ohci.c >> check-qtest-ppc64-y += tests/usb-hcd-uhci-test$(EXESUF) >> gcov-files-ppc64-y += hw/usb/hcd-uhci.c >> -check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF) >> -gcov-files-ppc64-y += hw/usb/hcd-xhci.c >> +check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF) >> +gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c >> check-qtest-ppc64-y += $(check-qtest-virtio-y) >> check-qtest-ppc64-$(CONFIG_SLIRP) += tests/test-netfilter$(EXESUF) >> check-qtest-ppc64-$(CONFIG_POSIX) += tests/test-filter-mirror$(EXESUF) > > I wonder whether the gcov lines are still up-to-date, or whether they > should include hcd-xhci-nec.c as well? (See commit 0bbb2f3df1ffd9ccf713 > for the split) I don't even know how to launch gcov. Not sure if I should put the $(CONFIG_foo) there. File is not consistent at all. Later, Juan.