From: "Alex Bennée" <alex.bennee@linaro.org>
To: Kamil Rytarowski <n54@gmx.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Detect native NetBSD curses(3)
Date: Mon, 08 May 2017 12:33:15 +0100 [thread overview]
Message-ID: <87shkf8txg.fsf@linaro.org> (raw)
In-Reply-To: <20170426105027.10666-1-n54@gmx.com>
Kamil Rytarowski <n54@gmx.com> writes:
> NetBSD ships with traditional BSD curses with compatibility with ncurses.
> qemu works nicely with the basesystem version of curses(3) from NetBSD.
>
> The only mismatch between curses(3) and ncurses is the lack of
> curses_version() in the NetBSD version. This function is used solely in
> the configure script, therefore eliminate it from the curses(3) detection.
>
> With this change applied, configure detects correctly curses frontend.
>
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configure | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index c35acf1192..17dc7224f7 100755
> --- a/configure
> +++ b/configure
> @@ -3034,14 +3034,13 @@ if test "$curses" != "no" ; then
> #include <curses.h>
> #include <wchar.h>
> int main(void) {
> - const char *s = curses_version();
> wchar_t wch = L'w';
> setlocale(LC_ALL, "");
> resize_term(0, 0);
> addwstr(L"wide chars\n");
> addnwstr(&wch, 1);
> add_wch(WACS_DEGREE);
> - return s != 0;
> + return 0;
> }
> EOF
> IFS=:
--
Alex Bennée
next prev parent reply other threads:[~2017-05-08 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 10:50 [Qemu-devel] [PATCH] configure: Detect native NetBSD curses(3) Kamil Rytarowski
2017-05-05 11:51 ` Kamil Rytarowski
2017-05-08 11:33 ` Alex Bennée [this message]
2017-05-20 23:17 ` Kamil Rytarowski
2017-05-20 23:35 ` Philippe Mathieu-Daudé
2017-05-23 14:43 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shkf8txg.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=n54@gmx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).