From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5DLt-0000aN-An for qemu-devel@nongnu.org; Fri, 11 Nov 2016 10:02:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5DLp-00086I-E3 for qemu-devel@nongnu.org; Fri, 11 Nov 2016 10:02:49 -0500 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:36280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c5DLp-00085r-7w for qemu-devel@nongnu.org; Fri, 11 Nov 2016 10:02:45 -0500 Received: by mail-wm0-x235.google.com with SMTP id g23so103247608wme.1 for ; Fri, 11 Nov 2016 07:02:45 -0800 (PST) References: <1478798481-25030-1-git-send-email-drjones@redhat.com> <1478798481-25030-9-git-send-email-drjones@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1478798481-25030-9-git-send-email-drjones@redhat.com> Date: Fri, 11 Nov 2016 15:02:42 +0000 Message-ID: <87shqy6ovh.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v5 08/11] libcflat: add IS_ALIGNED() macro, and page sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com, andre.przywara@arm.com, peter.maydell@linaro.org, marc.zyngier@arm.com, eric.auger@redhat.com, christoffer.dall@linaro.org, Peter Xu Andrew Jones writes: > From: Peter Xu > > These macros will be useful to do page alignment checks. > > Reviewed-by: Andre Przywara > Signed-off-by: Peter Xu > [drew: also added SZ_64K] > Signed-off-by: Andrew Jones > --- > lib/libcflat.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/libcflat.h b/lib/libcflat.h > index 82005f5d014f..143fc53061fe 100644 > --- a/lib/libcflat.h > +++ b/lib/libcflat.h > @@ -33,6 +33,12 @@ > #define __ALIGN_MASK(x, mask) (((x) + (mask)) & ~(mask)) > #define __ALIGN(x, a) __ALIGN_MASK(x, (typeof(x))(a) - 1) > #define ALIGN(x, a) __ALIGN((x), (a)) > +#define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) > + > +#define SZ_4K (0x1000) > +#define SZ_64K (0x10000) > +#define SZ_2M (0x200000) > +#define SZ_1G (0x40000000) We don't seem to use IS_ALIGNED, or in fact anything apart from SZ_64K (which is multiplied by 2 anyway) so I'm not sure if this patch is worth it for this series. Stylistically I thought (1 << foo) was preferred for setting of individual bits? Otherwise I'd be tempted to line the values up with zero padding to make it easier to read the bit position. > > typedef uint8_t u8; > typedef int8_t s8; -- Alex Bennée