From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: Richard Henderson <rth@twiddle.net>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org
Subject: Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction
Date: Thu, 28 Jul 2016 23:03:25 +0530 [thread overview]
Message-ID: <87shutllay.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <dd728647-3095-2d70-dcbf-ecf4cbdd0c72@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote:
>> + tcg_gen_ext32s_tl(dst, src);
>> + if (sh != 0) {
>> + tcg_gen_shli_tl(dst, dst, sh);
>> + }
>
> You need not test for sh != 0, since that will be done in
> tcg_gen_shli_tl.
Sure, will updated.
> Otherwise,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
>
>
> r~
prev parent reply other threads:[~2016-07-28 17:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 6:49 [Qemu-devel] [PATCH v1 0/8] POWER9 TCG enablements - part2 Nikunj A Dadhania
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 1/8] target-ppc: implement branch-less divw[o][.] Nikunj A Dadhania
2016-07-28 12:44 ` Richard Henderson
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 2/8] target-ppc: implement branch-less divd[o][.] Nikunj A Dadhania
2016-07-28 12:45 ` Richard Henderson
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 3/8] target-ppc: add dtstsfi[q] instructions Nikunj A Dadhania
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 4/8] target-ppc: add vabsdu[b, h, w] instructions Nikunj A Dadhania
2016-07-28 12:52 ` Richard Henderson
2016-07-28 17:21 ` Nikunj A Dadhania
2016-07-29 3:46 ` David Gibson
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions Nikunj A Dadhania
2016-07-28 12:55 ` Richard Henderson
2016-07-28 17:31 ` Nikunj A Dadhania
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 6/8] target-ppc: add vslv instruction Nikunj A Dadhania
2016-07-28 13:00 ` Richard Henderson
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 7/8] target-ppc: add vsrv instruction Nikunj A Dadhania
2016-07-28 13:01 ` Richard Henderson
2016-07-28 6:49 ` [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction Nikunj A Dadhania
2016-07-28 13:04 ` Richard Henderson
2016-07-28 17:33 ` Nikunj A Dadhania [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shutllay.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me \
--to=nikunj@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).