From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZG5r-0003fT-Qk for qemu-devel@nongnu.org; Fri, 26 Feb 2016 05:57:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZG5o-0004GM-Kd for qemu-devel@nongnu.org; Fri, 26 Feb 2016 05:57:55 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:38091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZG5o-0004G2-7U for qemu-devel@nongnu.org; Fri, 26 Feb 2016 05:57:52 -0500 Received: by mail-wm0-x22e.google.com with SMTP id a4so64878581wme.1 for ; Fri, 26 Feb 2016 02:57:51 -0800 (PST) References: <1456156787-17509-1-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1456156787-17509-1-git-send-email-alex.bennee@linaro.org> Date: Fri, 26 Feb 2016 10:57:48 +0000 Message-ID: <87si0f7n83.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v7 0/9] qemu-log, -dfilter and other logging tweaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com, dgilbert@redhat.com, aurelien@aurel32.net, rth@twiddle.net Alex Bennée writes: > As soft-freeze is approaching I'm trying to get these off my queue. v6 > missed out one of the review comments - now I believe all review > comments since v5 have been addressed. The two patches that have seen > the most change are: > > qemu-log: new option -dfilter to limit output > qemu-log: support simple pid substitution for logs > > The later having been moved up the patch queue as both now include > unit tests to defend their parsing behaviour. > > As usual the details are in the individual commits. I think these > patches are now ready to be picked up by the TCG tree? Ping? Any chance of a final sign-off and merge before soft-freeze? > > Alex Bennée (7): > tcg: pass down TranslationBlock to tcg_code_gen > qemu-log: correct help text for -d cpu > qemu-log: new option -dfilter to limit output > qemu-log: dfilter-ise exec, out_asm, op and opt_op > target-arm: dfilter support for in_asm > qemu-log: support simple pid substitution for logs > cputlb: modernise the debug support > > Peter Maydell (2): > qemu-log: Avoid function call for disabled qemu_log_mask logging > qemu-log: Improve the "exec" TB execution logging > > cpu-exec.c | 21 ++++---- > cputlb.c | 54 +++++++++++++------- > include/exec/exec-all.h | 5 ++ > include/qemu/log.h | 28 ++++++++++- > qemu-options.hx | 18 +++++++ > target-arm/translate-a64.c | 3 +- > target-arm/translate.c | 3 +- > tcg/tcg.c | 12 +++-- > tcg/tcg.h | 2 +- > tests/Makefile | 4 ++ > tests/test-logging.c | 114 ++++++++++++++++++++++++++++++++++++++++++ > translate-all.c | 5 +- > util/log.c | 120 +++++++++++++++++++++++++++++++++++++++------ > vl.c | 3 ++ > 14 files changed, 338 insertions(+), 54 deletions(-) > create mode 100644 tests/test-logging.c -- Alex Bennée